From 7c4cac538dc7facf3c3334863ec3a49b14e16630 Mon Sep 17 00:00:00 2001 From: nuintun <1730277+nuintun@users.noreply.github.com> Date: Tue, 10 Nov 2020 05:23:42 -0600 Subject: [PATCH 1/4] fix: compatibility with set headers option (#763) --- src/middleware.js | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/middleware.js b/src/middleware.js index 0c5566946..bb06f3478 100644 --- a/src/middleware.js +++ b/src/middleware.js @@ -79,8 +79,19 @@ export default function wrapper(context) { } if (headers) { - for (const name of Object.keys(headers)) { - res.setHeader(name, headers[name]); + const names = Object.keys(headers); + + // Express API + if(res.set) { + for (const name of names) { + res.set(name, headers[name]); + } + } + // Node.js API + else { + for (const name of names) { + res.setHeader(name, headers[name]); + } } } From fa99fc7f106569fe0cfb5d325094574bc5333126 Mon Sep 17 00:00:00 2001 From: Alexander Akait Date: Tue, 10 Nov 2020 14:38:35 +0300 Subject: [PATCH 2/4] refactor: code (#764) --- src/middleware.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/middleware.js b/src/middleware.js index bb06f3478..e20be8506 100644 --- a/src/middleware.js +++ b/src/middleware.js @@ -80,16 +80,14 @@ export default function wrapper(context) { if (headers) { const names = Object.keys(headers); - - // Express API - if(res.set) { - for (const name of names) { + + for (const name of names) { + // Express API + if (res.set) { res.set(name, headers[name]); } - } - // Node.js API - else { - for (const name of names) { + // Node.js API + else { res.setHeader(name, headers[name]); } } From 8d6cf9d38dcbb5e59a2296682975fed0d05d700c Mon Sep 17 00:00:00 2001 From: evilebottnawi Date: Tue, 10 Nov 2020 15:17:06 +0300 Subject: [PATCH 3/4] chore(release): 4.0.2 --- CHANGELOG.md | 7 +++++++ package-lock.json | 2 +- package.json | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1ebe74cdf..b33627318 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,13 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### [4.0.2](https://github.com/webpack/webpack-dev-middleware/compare/v4.0.1...v4.0.2) (2020-11-10) + + +### Bug Fixes + +* compatibility with set headers option ([#763](https://github.com/webpack/webpack-dev-middleware/issues/763)) ([7c4cac5](https://github.com/webpack/webpack-dev-middleware/commit/7c4cac538dc7facf3c3334863ec3a49b14e16630)) + ### [4.0.1](https://github.com/webpack/webpack-dev-middleware/compare/v4.0.0...v4.0.1) (2020-11-09) diff --git a/package-lock.json b/package-lock.json index 5be1350f2..0c5d859e1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "webpack-dev-middleware", - "version": "4.0.1", + "version": "4.0.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 738f7cd5f..c5016f644 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "webpack-dev-middleware", - "version": "4.0.1", + "version": "4.0.2", "description": "A development middleware for webpack", "license": "MIT", "repository": "webpack/webpack-dev-middleware", From 2163e13ea6f17c1e1995f7c2d11cd3fc56e89d25 Mon Sep 17 00:00:00 2001 From: evilebottnawi Date: Tue, 10 Nov 2020 15:17:53 +0300 Subject: [PATCH 4/4] chore(release): 4.0.2 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b33627318..b63c94e17 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ All notable changes to this project will be documented in this file. See [standa ### Bug Fixes -* compatibility with set headers option ([#763](https://github.com/webpack/webpack-dev-middleware/issues/763)) ([7c4cac5](https://github.com/webpack/webpack-dev-middleware/commit/7c4cac538dc7facf3c3334863ec3a49b14e16630)) +* compatibility with the `headers` option ([#763](https://github.com/webpack/webpack-dev-middleware/issues/763)) ([7c4cac5](https://github.com/webpack/webpack-dev-middleware/commit/7c4cac538dc7facf3c3334863ec3a49b14e16630)) ### [4.0.1](https://github.com/webpack/webpack-dev-middleware/compare/v4.0.0...v4.0.1) (2020-11-09) pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy