From 58c6b7422aedfd3fc4d5f3553b196da40eae1f4b Mon Sep 17 00:00:00 2001 From: Alexander Akait <4567934+alexander-akait@users.noreply.github.com> Date: Fri, 1 Nov 2024 03:46:06 +0300 Subject: [PATCH 1/2] fix: prefetch and preload runtime generation (#1116) --- src/index.js | 4 ++-- test/cases/prefetch-preload-hmr/a.css | 3 +++ test/cases/prefetch-preload-hmr/b.js | 0 .../prefetch-preload-hmr/expected/main.css | 4 ++++ test/cases/prefetch-preload-hmr/index.js | 3 +++ .../prefetch-preload-hmr/webpack.config.js | 21 +++++++++++++++++++ 6 files changed, 33 insertions(+), 2 deletions(-) create mode 100644 test/cases/prefetch-preload-hmr/a.css create mode 100644 test/cases/prefetch-preload-hmr/b.js create mode 100644 test/cases/prefetch-preload-hmr/expected/main.css create mode 100644 test/cases/prefetch-preload-hmr/index.js create mode 100644 test/cases/prefetch-preload-hmr/webpack.config.js diff --git a/src/index.js b/src/index.js index 7fc94b01..b7caa4bb 100644 --- a/src/index.js +++ b/src/index.js @@ -1123,7 +1123,7 @@ class MiniCssExtractPlugin { ]) : "// no hmr", "", - withPrefetch && hasCssMatcher !== false + withPrefetch && withLoading && hasCssMatcher !== false ? `${ RuntimeGlobals.prefetchChunkHandlers }.miniCss = ${runtimeTemplate.basicFunction("chunkId", [ @@ -1159,7 +1159,7 @@ class MiniCssExtractPlugin { ])};` : "// no prefetching", "", - withPreload && hasCssMatcher !== false + withPreload && withLoading && hasCssMatcher !== false ? `${ RuntimeGlobals.preloadChunkHandlers }.miniCss = ${runtimeTemplate.basicFunction("chunkId", [ diff --git a/test/cases/prefetch-preload-hmr/a.css b/test/cases/prefetch-preload-hmr/a.css new file mode 100644 index 00000000..5451a331 --- /dev/null +++ b/test/cases/prefetch-preload-hmr/a.css @@ -0,0 +1,3 @@ +.a { + color: red; +} diff --git a/test/cases/prefetch-preload-hmr/b.js b/test/cases/prefetch-preload-hmr/b.js new file mode 100644 index 00000000..e69de29b diff --git a/test/cases/prefetch-preload-hmr/expected/main.css b/test/cases/prefetch-preload-hmr/expected/main.css new file mode 100644 index 00000000..98f445d8 --- /dev/null +++ b/test/cases/prefetch-preload-hmr/expected/main.css @@ -0,0 +1,4 @@ +.a { + color: red; +} + diff --git a/test/cases/prefetch-preload-hmr/index.js b/test/cases/prefetch-preload-hmr/index.js new file mode 100644 index 00000000..e615a5ec --- /dev/null +++ b/test/cases/prefetch-preload-hmr/index.js @@ -0,0 +1,3 @@ +import "./a.css"; + +import(/* webpackPrefetch: true */ "./b"); diff --git a/test/cases/prefetch-preload-hmr/webpack.config.js b/test/cases/prefetch-preload-hmr/webpack.config.js new file mode 100644 index 00000000..d07a9495 --- /dev/null +++ b/test/cases/prefetch-preload-hmr/webpack.config.js @@ -0,0 +1,21 @@ +import webpack from "webpack"; + +import Self from "../../../src"; + +module.exports = { + entry: "./index.js", + module: { + rules: [ + { + test: /\.css$/, + use: [Self.loader, "css-loader"], + }, + ], + }, + plugins: [ + new Self({ + filename: "[name].css", + }), + new webpack.HotModuleReplacementPlugin(), + ], +}; From 3effaa0319bad5cc1bf0ae760553bf7abcbc35a4 Mon Sep 17 00:00:00 2001 From: "alexander.akait" Date: Fri, 1 Nov 2024 03:46:35 +0300 Subject: [PATCH 2/2] chore(release): 2.9.2 --- CHANGELOG.md | 7 +++++++ package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 84831237..af554f8f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,13 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### [2.9.2](https://github.com/webpack-contrib/mini-css-extract-plugin/compare/v2.9.1...v2.9.2) (2024-11-01) + + +### Bug Fixes + +* prefetch and preload runtime generation ([#1116](https://github.com/webpack-contrib/mini-css-extract-plugin/issues/1116)) ([58c6b74](https://github.com/webpack-contrib/mini-css-extract-plugin/commit/58c6b7422aedfd3fc4d5f3553b196da40eae1f4b)) + ### [2.9.1](https://github.com/webpack-contrib/mini-css-extract-plugin/compare/v2.9.0...v2.9.1) (2024-08-19) diff --git a/package-lock.json b/package-lock.json index 58daef93..e6cdb38a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "mini-css-extract-plugin", - "version": "2.9.1", + "version": "2.9.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "mini-css-extract-plugin", - "version": "2.9.1", + "version": "2.9.2", "license": "MIT", "dependencies": { "schema-utils": "^4.0.0", diff --git a/package.json b/package.json index ef5701b2..983a8ca0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "mini-css-extract-plugin", - "version": "2.9.1", + "version": "2.9.2", "description": "extracts CSS into separate files", "license": "MIT", "repository": "webpack-contrib/mini-css-extract-plugin", pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy