From 08032b13c939f13d80f6e73730d6fd3f6238b90a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=92=9F=E8=BF=9C=E7=BB=B4?= Date: Tue, 14 Feb 2023 17:07:58 +0800 Subject: [PATCH 1/4] fix: avoid to throw error when link doesn't have parentNode --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index d89d4fa9..28c811c6 100644 --- a/src/index.js +++ b/src/index.js @@ -862,7 +862,7 @@ class MiniCssExtractPlugin { 'err.code = "CSS_CHUNK_LOAD_FAILED";', "err.type = errorType;", "err.request = realHref;", - "linkTag.parentNode.removeChild(linkTag)", + "if(linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)", "reject(err);", ]), "}", From 9189ab871d39205bb23167a61f2d68cfd77e6b59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=92=9F=E8=BF=9C=E7=BB=B4?= Date: Thu, 16 Feb 2023 11:17:30 +0800 Subject: [PATCH 2/4] refactor: add space after if --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index 28c811c6..6a5969e1 100644 --- a/src/index.js +++ b/src/index.js @@ -862,7 +862,7 @@ class MiniCssExtractPlugin { 'err.code = "CSS_CHUNK_LOAD_FAILED";', "err.type = errorType;", "err.request = realHref;", - "if(linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)", + "if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)", "reject(err);", ]), "}", From 2ecbe35dd9e3c0b17b376864fa7cad56ab5d3151 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=92=9F=E8=BF=9C=E7=BB=B4?= Date: Mon, 20 Feb 2023 11:07:25 +0800 Subject: [PATCH 3/4] fix: fix test case error --- ...{0.4568ffdcdfced785eabc.css => 0.b1a0d51fa05593feebfa.css} | 0 .../{4568ffdcdfced785eabc.css => b1a0d51fa05593feebfa.css} | 0 .../expected/webpack-5-importModule/main.js | 4 ++-- test/cases/chunkFilename-fullhash/expected/webpack-5/main.js | 2 +- test/cases/hmr/expected/main.js | 2 +- test/cases/insert-function/expected/main.js | 2 +- test/cases/insert-string/expected/main.js | 2 +- test/cases/insert-undefined/expected/main.js | 2 +- 8 files changed, 7 insertions(+), 7 deletions(-) rename test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/{0.4568ffdcdfced785eabc.css => 0.b1a0d51fa05593feebfa.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/{4568ffdcdfced785eabc.css => b1a0d51fa05593feebfa.css} (100%) diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.4568ffdcdfced785eabc.css b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.b1a0d51fa05593feebfa.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.4568ffdcdfced785eabc.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.b1a0d51fa05593feebfa.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/4568ffdcdfced785eabc.css b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/b1a0d51fa05593feebfa.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/4568ffdcdfced785eabc.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/b1a0d51fa05593feebfa.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js index 462b4287..dab8a337 100644 --- a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js +++ b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__); /******/ /******/ /* webpack/runtime/getFullHash */ /******/ (() => { -/******/ __webpack_require__.h = () => ("4568ffdcdfced785eabc") +/******/ __webpack_require__.h = () => ("b1a0d51fa05593feebfa") /******/ })(); /******/ /******/ /* webpack/runtime/global */ @@ -189,7 +189,7 @@ __webpack_require__.r(__webpack_exports__); /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js index 68c828cc..62cf7589 100644 --- a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js +++ b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js @@ -189,7 +189,7 @@ __webpack_require__.r(__webpack_exports__); /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/hmr/expected/main.js b/test/cases/hmr/expected/main.js index 581539a3..4da2968a 100644 --- a/test/cases/hmr/expected/main.js +++ b/test/cases/hmr/expected/main.js @@ -952,7 +952,7 @@ __webpack_require__.r(__webpack_exports__); /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/insert-function/expected/main.js b/test/cases/insert-function/expected/main.js index 96349f1f..ce2a297e 100644 --- a/test/cases/insert-function/expected/main.js +++ b/test/cases/insert-function/expected/main.js @@ -173,7 +173,7 @@ /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/insert-string/expected/main.js b/test/cases/insert-string/expected/main.js index 04dd03fd..686c75ab 100644 --- a/test/cases/insert-string/expected/main.js +++ b/test/cases/insert-string/expected/main.js @@ -173,7 +173,7 @@ /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/insert-undefined/expected/main.js b/test/cases/insert-undefined/expected/main.js index ea87a2bc..08a077d9 100644 --- a/test/cases/insert-undefined/expected/main.js +++ b/test/cases/insert-undefined/expected/main.js @@ -173,7 +173,7 @@ /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } From 0ace6b9e9487e82189f19cef2a7939157d6f0f5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=92=9F=E8=BF=9C=E7=BB=B4?= Date: Mon, 20 Feb 2023 14:41:30 +0800 Subject: [PATCH 4/4] fix: fix test case error --- .../{0.9ee2d65d5d13f2b4323d.css => 0.775d09b0a3e56e73fd45.css} | 0 .../{9ee2d65d5d13f2b4323d.css => 775d09b0a3e56e73fd45.css} | 0 test/cases/chunkFilename-fullhash/expected/webpack-5/main.js | 2 +- 3 files changed, 1 insertion(+), 1 deletion(-) rename test/cases/chunkFilename-fullhash/expected/webpack-5/{0.9ee2d65d5d13f2b4323d.css => 0.775d09b0a3e56e73fd45.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5/{9ee2d65d5d13f2b4323d.css => 775d09b0a3e56e73fd45.css} (100%) diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/0.9ee2d65d5d13f2b4323d.css b/test/cases/chunkFilename-fullhash/expected/webpack-5/0.775d09b0a3e56e73fd45.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5/0.9ee2d65d5d13f2b4323d.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5/0.775d09b0a3e56e73fd45.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/9ee2d65d5d13f2b4323d.css b/test/cases/chunkFilename-fullhash/expected/webpack-5/775d09b0a3e56e73fd45.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5/9ee2d65d5d13f2b4323d.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5/775d09b0a3e56e73fd45.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js index 62cf7589..98b38564 100644 --- a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js +++ b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__); /******/ /******/ /* webpack/runtime/getFullHash */ /******/ (() => { -/******/ __webpack_require__.h = () => ("9ee2d65d5d13f2b4323d") +/******/ __webpack_require__.h = () => ("775d09b0a3e56e73fd45") /******/ })(); /******/ /******/ /* webpack/runtime/global */ pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy