Write chunks with negative zero values and a zero fill value

bojidar-bg · bojidar-bg · commit c4904e3b9d43 · 2025-07-08T14:52:54.000+03:00
Fixes #3144
diff --git a/changes/3144.bugfix.rst b/changes/3144.bugfix.rst
@@ -0,0 +1 @@
+For arrays with ``config={"write_empty_chunks: False}`` and ``fill_value=0.0`` (default), chunks containing negative zeroes are written out.
diff --git a/src/zarr/core/buffer/core.py b/src/zarr/core/buffer/core.py
@@ -523,6 +523,12 @@ def all_equal(self, other: Any, equal_nan: bool = True) -> bool:
         if other is None:
             # Handle None fill_value for Zarr V2
             return False
+        if other == 0.0 and self._data.dtype.kind not in ("U", "S", "T", "O", "V"):
+            # Handle positive and negative zero
+            if np.any(self._data):  # Check for any truthy value
+                return False
+            # Check signs:
+            return np.array_equiv(np.signbit(self._data), np.signbit(other))
         # use array_equal to obtain equal_nan=True functionality
         # Since fill-value is a scalar, isn't there a faster path than allocating a new array for fill value
         # every single time we have to write data?
diff --git a/tests/test_array.py b/tests/test_array.py
@@ -904,6 +904,30 @@ def test_write_empty_chunks_behavior(
         assert arr.nchunks_initialized == arr.nchunks
 
 
+@pytest.mark.parametrize("store", ["memory"], indirect=True)
+@pytest.mark.parametrize("fill_value", [0.0, -0.0])
+def test_write_empty_chunks_negative_zero(
+    zarr_format: ZarrFormat, store: MemoryStore, fill_value: float
+) -> None:
+    # regression test for https://github.com/zarr-developers/zarr-python/issues/3144
+
+    arr = zarr.create_array(
+        store=store,
+        shape=(2,),
+        zarr_format=zarr_format,
+        dtype="f4",
+        fill_value=fill_value,
+        chunks=(1,),
+        config={"write_empty_chunks": False},
+    )
+
+    assert arr.nchunks_initialized == 0
+
+    # initialize the with the negated fill value (-0.0 for +0.0, +0.0 for -0.0)
+    arr[:] = -fill_value
+    assert arr.nchunks_initialized == arr.nchunks
+
+
 @pytest.mark.parametrize(
     ("fill_value", "expected"),
     [

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+For arrays with ``config={"write_empty_chunks: False}`` and ``fill_value=0.0`` (default), chunks containing negative zeroes are written out.