Use range of integers as out_selection not slice in CoordinateIndexer

aldenks · aldenks · commit f1b58d44b399 · 2025-06-06T16:34:21.000-04:00
To fix issue when using vindex with repeated indexes in indexer
diff --git a/src/zarr/core/indexing.py b/src/zarr/core/indexing.py
@@ -1193,7 +1193,7 @@ def __iter__(self) -> Iterator[ChunkProjection]:
             stop = self.chunk_nitems_cumsum[chunk_rix]
             out_selection: slice | npt.NDArray[np.intp]
             if self.sel_sort is None:
-                out_selection = slice(start, stop)
+                out_selection = np.arange(start, stop)
             else:
                 out_selection = self.sel_sort[start:stop]
 
diff --git a/tests/test_properties.py b/tests/test_properties.py
@@ -152,14 +152,6 @@ def test_vindex(data: st.DataObject) -> None:
     actual = zarray.vindex[indexer]
     assert_array_equal(nparray[indexer], actual)
 
-    # FIXME!
-    # when the indexer is such that a value gets overwritten multiple times,
-    # I think the output depends on chunking.
-    # new_data = data.draw(npst.arrays(shape=st.just(actual.shape), dtype=nparray.dtype))
-    # nparray[indexer] = new_data
-    # zarray.vindex[indexer] = new_data
-    # assert_array_equal(nparray, zarray[:])
-
 
 @given(store=stores, meta=array_metadata())  # type: ignore[misc]
 async def test_roundtrip_array_metadata_from_store(
