Page MenuHomePhabricator

Gadgets should use the current skin, instead of the skin preference
Closed, ResolvedPublic

Description

The user's preference usually reflects the displayed skin, however this isn't
true if the useskin URL query is set, or MobileFrontend is being used.

Event Timeline

Change 299950 had a related patch set uploaded (by TheDJ; owner: Majr):
[mediawiki/extensions/Gadgets@master] Fix skins option to use currently displayed skin, rather than user preference

https://gerrit.wikimedia.org/r/299950

Will need a fix for the api module. Makes me wonder what the implied behavior of isAllowed (and the corresponding api flag) is actually supposed to be. Would be nice if we could track down what the original intent was 'relevant to the user' or 'allowed for the user'. Did the first just get slapped onto the latter ?

See T33414: Skin specific gadgets
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Gadgets/+/3854/-1..3

Change 299950 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@master] Fix skins option to use currently displayed skin, rather than user preference

https://gerrit.wikimedia.org/r/299950

TheDJ claimed this task.
TheDJ reassigned this task from TheDJ to Majr.
TheDJ removed a project: Patch-For-Review.
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy