Probably it should be replaced with parseAsContent, but that's only available in 1.32.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Removes usage of deprecated OutputPage::parse | mediawiki/extensions/Translate | master | +4 -2 |
Event Timeline
Change 518296 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Removes usage of deprecated OutputPage::parse
During testing Niklas found that that external link icon disappears when this patch is applied.
I did some digging regarding this and I've documented findings here - https://www.mediawiki.org/wiki/User:APatro_(WMF)/OutPutPage::parse
Summary,
Output from parse is wrapped in a div tag with class mw-parser-output whereas the output from parseAsContent is not.
I think it is expected for the parser content to be wrapped inside a container with .mw-parser-output class. Hence updated the patch to add this.
During testing I also noticed that the editable documentation does not have the mw-parser-output class either causing the external link icon not to appear there either.
@Nikerabbit - Would you like me to file a task to fix this?
Change 518296 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Removes usage of deprecated OutputPage::parse
Hi @Pginer-WMF
Can you please add this to the current sprint? Work on this started before we started adding Translate extensions tasks on the Language board.
@Jpita - We will test this change once we have the deployment on Translatewiki.net on 25th July. Niklas has already tested this locally so, I'll move this to Recheck after deployment.
This hasn't been deployed on Translatewiki.net, which AFAIK is the only known user of this code. Leaving this in PROD QA