Deprecate Skin::makeVariablesScript
Closed, ResolvedPublic
Actions

Description

Skin::makeVariablesScript is a wrapper for ResourceLoader::makeInlineScript
I see no reason for it to be part of the Skin when this can easily be replicated outside the Skin so let's mark as deprecated

acceptance criteria

SecurePoll no longer uses Skin::makeVariablesScript
The method is deprecated in core

Details

	Subject	Repo	Branch	Lines +/-
	Deprecate Skin::makeVariablesScript()	mediawiki/core	master	+13 -3
	SecurePoll: Remove usage of Skin::makeVariablesScript()	mediawiki/extensions/SecurePoll	master	+7 -9

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jul 14 2020, 10:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 10:28 PM

Jdlrobson moved this task from It's complicated to Phase 2 - Deprecate and remove Skin methods for readability on the MediaWiki-Core-Skin-Architecture board.Jul 14 2020, 10:28 PM

Ammarpad added a project: MediaWiki-extensions-SecurePoll.Aug 19 2020, 2:26 AM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptAug 19 2020, 2:26 AM

Ammarpad claimed this task.Aug 20 2020, 9:30 AM

Let us know if there's anything that we need to do here. Is SecurePoll tagged because we need to remove the deprecated call...?

@eprodromou correct.
https://gerrit.wikimedia.org/g/mediawiki/extensions/SecurePoll/+/1193542637177af955edf8c4cdfb0247455463be/includes/Pages/ListPage.php#120
Hopefully straightforward and will probably just need some help with review!

Jdlrobson moved this task from Backlog to Skinning system on the MediaWiki-User-Interface board.Aug 27 2020, 4:48 PM

Change 623838 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/SecurePoll@master] SecurePoll: Remove usage of Skin::makeVariablesScript()

https://gerrit.wikimedia.org/r/623838

gerritbot added a project: Patch-For-Review.Sep 2 2020, 5:41 PM

Hope it;s okay to move this back into your inbox for review of the above patch.

• eprodromou edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Sep 15 2020, 8:42 PM

• eprodromou moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.

Moving back to later since the same method needs to be replaced in more places. See https://codesearch.wmcloud.org/search/?q=Skin%3A%3AmakeVariablesScript&i=nope&files=&repos=

Removed patch for review tag. Please re-add when other patches are ready.

Change 623838 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] SecurePoll: Remove usage of Skin::makeVariablesScript()

https://gerrit.wikimedia.org/r/623838

Jdlrobson removed a project: MediaWiki-extensions-SecurePoll.Sep 17 2020, 6:27 PM

Jdlrobson updated the task description. (Show Details)

Moving back to later since the same method needs to be replaced in more places. See https://codesearch.wmcloud.org/search/?q=Skin%3A%3AmakeVariablesScript&i=nope&files=&repos= Removed patch for review tag. Please re-add when other patches are ready.

It's allowed to hard-deprecate the code while non-wikimedia-deployed extensions are still using it. So the code search should be https://codesearch.wmcloud.org/deployed/?q=Skin%3A%3AmakeVariablesScript&i=nope&files=&repos=

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 17 2020, 7:00 PM

Change 628576 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin::makeVariablesScript()

https://gerrit.wikimedia.org/r/628576

gerritbot added a project: Patch-For-Review.Sep 20 2020, 10:35 AM

Change 628576 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin::makeVariablesScript()

https://gerrit.wikimedia.org/r/628576

Jdlrobson closed this task as Resolved.Sep 21 2020, 8:32 PM

Jdlrobson updated the task description. (Show Details)

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2020, 9:11 PM