Page MenuHomePhabricator

Installer generates incorrect wgDefaultSkin for MinervaNeue
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue :

  • docker run -d --name some-mediawiki -p 8080:80 -v mw_html:/var/www/html -v mw_data:/var/www/data mediawiki:1.40
  • Go to http://localhost:8080/mw-config/index.php
    • Choose SQLite as database
    • Choose Ask me more questions
    • Choose Use this skin as default for MinervaNeue
  • Download the generated LocalSettings.php and copy it to the container: docker cp LocalSettings.php some-mediawiki:/var/www/html/LocalSettings.php
  • Restart the container: docker restart some-mediawiki
  • Go again to http://localhost:8080

What happens?:

The skin is not loaded, and there is a warning: Whoops! The default skin for your wiki, defined in $wgDefaultSkin as minervaneue, is not available.

In the generated LocalSettings.php, there is this line:

$wgDefaultSkin = "minervaneue";

What should have happened instead?:

According to https://www.mediawiki.org/wiki/Skin:Minerva_Neue, the line should be:

$wgDefaultSkin = 'minerva';

Replacing minervaneue by minerva in the container fixes the issue: docker exec some-mediawiki sed -i 's/minervaneue/minerva/' /var/www/html/LocalSettings.php

Software version : 1.40

Other information :

Reproduced with multiple browsers (Firefox, Chromium). Here is a screenshot:

Screenshot from 2023-09-14 15-13-02.png (854×1 px, 162 KB)

Event Timeline

See T164408. Apparently that did not happen. So it needs special casing in the installer.

Change 963707 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Installer: Make Minerva works correctly for $wgDefaultSkin

https://gerrit.wikimedia.org/r/963707

I'd rather we re-named (either the repo or the skin) than carried a hack, but fixing it now will be painful. Eurgh.

Change 963707 merged by jenkins-bot:

[mediawiki/core@master] Installer: Make Minerva works correctly for $wgDefaultSkin

https://gerrit.wikimedia.org/r/963707

Contrary to what RTB just tagged this task with, this (just) made the REL1_41 cut; does this need back-porting to REL1_40?

Change 966606 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@REL1_40] Installer: Make Minerva works correctly for $wgDefaultSkin

https://gerrit.wikimedia.org/r/966606

does this need back-porting to REL1_40?

done

Change 966606 merged by jenkins-bot:

[mediawiki/core@REL1_40] Installer: Make Minerva works correctly for $wgDefaultSkin

https://gerrit.wikimedia.org/r/966606

Ammarpad claimed this task.
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy