Page MenuHomePhabricator
Create Task
Maniphest T377672

Nearby articles do not work
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Datawikipersoncontributor
Sun, Oct 20, 11:26 AM
Tags
Referenced Files
F57640463: 2024-10-24_13-59-19.mp4.gif
Thu, Oct 24, 9:02 PM
F57634691: screenshot 33.mov.gif
Tue, Oct 22, 9:20 PM
F57629731: IMG_0140.png
Mon, Oct 21, 6:55 AM
F57627840: Screenshot 2024-10-20 at 15.38.18.png
Sun, Oct 20, 2:38 PM
F57627835: Screenshot 2024-10-20 at 15.37.10.png
Sun, Oct 20, 2:38 PM
F57627560: ScreenRecording_10-20-2024 14-17-07_1.mp4
Sun, Oct 20, 11:26 AM
F57627553: ScreenRecording_10-20-2024 14-16-20_1.mp4
Sun, Oct 20, 11:26 AM
Subscribers
Aklapper
dancy
Datawikipersoncontributor
Edtadros
Esanders
GMikesell-WMF
Jdlrobson
View All 9 Subscribers

Description

Steps to replicate the issue (include links if applicable):

Press show nearby pages

What happens?:
Nothing happens. It does ask for permission for my location first time it happened, but after that nothing happens. Here’s video proof.

ScreenRecording_10-20-2024 14-16-20_1.mp42 MBDownload

What should have happened instead?:
It should have actually worked! It should have told me events around me which were notable enough to have a Wikipedia page, Like this:

ScreenRecording_10-20-2024 14-17-07_1.mp43 MBDownload

Okay, I’ll admit, I am in a boring place.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
iOS 18.0.1
Other information (browser name/version, screenshots, etc.):
Chrome

By the way, this is Test wiki, so it has nothing to do with the main wiki, which is why it is simple English.

Requirement

Fix the issue where the Nearby articles feature on simple.m.wikipedia.beta.wmflabs.org is not showing notable nearby Wikipedia pages as expected when accessed via the mobile interface.

BDD

Feature: Nearby articles function

  Scenario: Viewing nearby Wikipedia articles on mobile
    Given the user is on simple.m.wikipedia.beta.wmflabs.org
    And they press the "Nearby" icon from the menu
    When they press "Show nearby pages"
    Then the system should display notable nearby Wikipedia articles.

Test Steps

Test Case 1: Verify Nearby articles functionality

  1. Go to https://simple.m.wikipedia.beta.wmflabs.org.
  2. Press the three-line button (menu).
  3. Press the Nearby icon to search for nearby articles.
  4. Press “Show nearby pages.”
  5. AC1: Confirm that notable nearby Wikipedia pages are displayed.

QA Results - Beta

ACStatusDetails
1✅T377672#10252207

QA Results - Prod

ACStatusDetails
1✅T377672#10260766

Details

SubjectRepoBranchLines +/-
Follow-up I7e66bd7517: Only emit onRouterHashChange when the hash changesmediawiki/coremaster+5 -2
Revert "mediawiki.router: Call onRouterHashChange after push/replaceState"mediawiki/coremaster+4 -13
Customize query in gerrit

Related Objects

Event Timeline

Datawikipersoncontributor created this task.Sun, Oct 20, 11:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSun, Oct 20, 11:26 AM
Nemoralis added a project: Beta-Cluster-reproducible.Sun, Oct 20, 11:31 AM
Reedy subscribed.Sun, Oct 20, 1:54 PM

Is it possible that simple on beta just doesn't have any articles actually anywhere near you?

For example, it should only show things within a 10KM range..

Do you have an examples of pages it should've shown? Do they have coordinates properly assigned etc?

If I look for me, the town I live in, doesn't have an article on simple beta, and therefore statistically, there's gonna be little else within that 10km range that might

Reedy added a comment.Sun, Oct 20, 2:38 PM

Except, it should still be wired up to production enwiki - https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings-labs.php

		'wgNearbyPagesUrl' => [
			'default' => 'https://en.wikipedia.org/w/api.php',
			'wikidatawiki'  => 'https://www.wikidata.org/w/api.php',
			'testwikidatawiki' => 'https://www.wikidata.org/w/api.php',
		],

I don't see any attempts to actually do an API request

Screenshot 2024-10-20 at 15.37.10.png (580×1 px, 163 KB)

But yet

Screenshot 2024-10-20 at 15.38.18.png (68×487 px, 16 KB)

Reedy added a comment.Sun, Oct 20, 6:21 PM

I think it is related to that "Too many calls to Location or History APIs within a short timeframe."

Which suggests two issues. One, the browser console shouldn't be the only place this is surfaced. It should be trapped and displayed to the user.

And the underlying issue why it seems to be constantly showing that...

gerritbot added a comment.Mon, Oct 21, 2:52 AM

Change #1081707 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Revert "mediawiki.router: Call onRouterHashChange after push/replaceState"

https://gerrit.wikimedia.org/r/1081707

gerritbot added a project: Patch-For-Review.Mon, Oct 21, 2:52 AM
Jdlrobson triaged this task as High priority.Mon, Oct 21, 2:53 AM
Jdlrobson subscribed.

There is an error in the console. git bisect points to the above patch (I'll follow up tomorrow):

jquery.js:3783 jQuery.Deferred exception: Maximum call stack size exceeded RangeError: Maximum call stack size exceeded
    at Router.onRouterHashChange (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:1:554)
    at Router.navigateTo (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:2:188)
    at Proxy.loadPages (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=%40w…e%7Cext.nearby.scripts%7Cmobile.startup&skin=minerva&version=13mz8:648:835)
    at Router.<anonymous> (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=%40w…e%7Cext.nearby.scripts%7Cmobile.startup&skin=minerva&version=13mz8:647:489)
    at Router.checkRoute (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:1:949)
    at Router.onRouterHashChange (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:1:663)
    at Router.navigateTo (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:2:188)
    at Proxy.loadPages (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=%40w…e%7Cext.nearby.scripts%7Cmobile.startup&skin=minerva&version=13mz8:648:835)
    at Router.<anonymous> (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=%40w…e%7Cext.nearby.scripts%7Cmobile.startup&skin=minerva&version=13mz8:647:489)
    at Router.checkRoute (https://simple.m.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=mediawiki.router&skin=minerva&version=awk05:1:949) undefined
Jdlrobson added a project: Web-Team-Backlog (FY2024-25 Q2 Sprint 2).Mon, Oct 21, 2:53 AM
Jdlrobson added a parent task: T375659: 1.43.0-wmf.28 deployment blockers.
Datawikipersoncontributor added a comment.Mon, Oct 21, 6:55 AM

For those who don’t understand, there should be a picture saying this:

IMG_0140.png (1×2 px, 205 KB)

But it shows nothing. Absolutely nothing. No uh oh! No Wikipedia article nearby you are something like that. Just the button shows it’s being clicked and that’s it!

gerritbot added a comment.Mon, Oct 21, 12:39 PM

Change #1081965 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] Follow-up I7e66bd7517: Only emit onRouterHashChange when the hash changes

https://gerrit.wikimedia.org/r/1081965

Esanders added subscribers: Krinkle, Esanders.Mon, Oct 21, 12:47 PM
In T377672#10245014, @Jdlrobson wrote:

There is an error in the console. git bisect points to the above patch (I'll follow up tomorrow):

Thanks for the investigation. It looks like @Krinkle is happy to review these if it is a distraction for you. I have a fix but we can also revert and try later.

gerritbot added a comment.Mon, Oct 21, 1:59 PM

Change #1081965 merged by jenkins-bot:

[mediawiki/core@master] Follow-up I7e66bd7517: Only emit onRouterHashChange when the hash changes

https://gerrit.wikimedia.org/r/1081965

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Mon, Oct 21, 2:00 PM
dancy subscribed.Mon, Oct 21, 3:55 PM

@Esanders Hello. I'm on train duty this wek and @Jdlrobson added this task as a train blocker. Can you ensure that the relevant fix is backported to the wmf/1.43.0-wmf.28 branch?

dancy added a comment.Mon, Oct 21, 5:03 PM
In T377672#10247106, @dancy wrote:

@Esanders Hello. I'm on train duty this wek and @Jdlrobson added this task as a train blocker. Can you ensure that the relevant fix is backported to the wmf/1.43.0-wmf.28 branch?

Disregard this. The .28 branch hasn't been created yet.

ovasileva moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2024-25 Q2 Sprint 2) board.Mon, Oct 21, 5:15 PM
Esanders added a comment.Mon, Oct 21, 5:20 PM

Disregard this. The .28 branch hasn't been created yet.

I was going to say :) It has been merged any the feature appears to be working fine on beta.

gerritbot added a comment.Mon, Oct 21, 7:47 PM

Change #1081707 abandoned by Jdlrobson:

[mediawiki/core@master] Revert "mediawiki.router: Call onRouterHashChange after push/replaceState"

Reason:

Thanks Ed! Abandoning now https://gerrit.wikimedia.org/r/q/I8f4ed957a4 has been merged.

https://gerrit.wikimedia.org/r/1081707

Jdlrobson assigned this task to Edtadros.Mon, Oct 21, 7:49 PM
Jdlrobson removed a parent task: T375659: 1.43.0-wmf.28 deployment blockers.
Maintenance_bot removed a project: Patch-For-Review.Mon, Oct 21, 8:30 PM
Edtadros updated the task description. (Show Details)Tue, Oct 22, 9:14 PM
Edtadros removed Edtadros as the assignee of this task.Tue, Oct 22, 9:20 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q2 Sprint 2) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Case 1: Verify Nearby articles functionality

  1. Go to https://simple.m.wikipedia.beta.wmflabs.org.
  2. Press the three-line button (menu).
  3. Press the Nearby icon to search for nearby articles.
  4. Press “Show nearby pages.”
  5. ✅ AC1: Confirm that notable nearby Wikipedia pages are displayed.

screenshot 33.mov.gif (1×1 px, 485 KB)

Edtadros updated the task description. (Show Details)Tue, Oct 22, 9:21 PM
Edtadros mentioned this in T377247: Verify 1.43.0-wmf.28 deployment.Thu, Oct 24, 2:46 AM
Jdlrobson assigned this task to ovasileva.Thu, Oct 24, 4:45 PM
GMikesell-WMF subscribed.Thu, Oct 24, 9:02 PM

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS 15.0
Browser: Chrome 130
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Case 1: Verify Nearby articles functionality

  1. Go to https://simple.m.wikipedia.org.
  2. Press the three-line button (menu).
  3. Press the Nearby icon to search for nearby articles.
  4. Press “Show nearby pages.”
  5. ✅ AC1: Confirm that notable nearby Wikipedia pages are displayed.

2024-10-24_13-59-19.mp4.gif (1×1 px, 855 KB)

GMikesell-WMF added a project: Verified.Thu, Oct 24, 9:04 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF removed a project: Verified.
ovasileva added a comment.Fri, Oct 25, 3:51 PM

Leaving open so we can give estimate before closing.

ovasileva closed this task as Resolved.Fri, Oct 25, 4:31 PM
ovasileva set the point value for this task to 1.

Put 1 point on it for the QA effort. Resolving!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy