Page MenuHomePhabricator

abbrvThreshold mismatch between commons as foreign repo and local commons breaking images with long names
Closed, ResolvedPublic

Description

Reported on https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Image_problem

Thumbnails of several embedded image (stored on commons) fail to show on enwiki, loading the thumbnail url gives:

Error generating thumbnail

The given path of the specified thumbnail is incorrect; expected 'e/e1/US_Navy_120209-N-XD935-302_Mass_Communication_Specialist_1st_Class_Shane_Tuck,_assigned_to_the_Expeditionary_Combat_Camera_Underwater_Photo_Team,_c.jpg/220px-US_Navy_120209-N-XD935-302_Mass_Communication_Specialist_1st_Class_Shane_Tuck,_assigned_to_the_Expeditionary_Combat_Camera_Underwater_Photo_Team,_c.jpg' but got 'e/e1/US_Navy_120209-N-XD935-302_Mass_Communication_Specialist_1st_Class_Shane_Tuck,_assigned_to_the_Expeditionary_Combat_Camera_Underwater_Photo_Team,_c.jpg/220px-thumbnail.jpg'.

On commons everything looks fine. Example images which produce the bug:

File:US Navy 120209-N-XD935-302 Mass Communication Specialist 1st Class Shane Tuck, assigned to the Expeditionary Combat Camera Underwater Photo Team, c.jpg

File:1801 Cary Map of the East Indies and Southeast Asia ( Singapore, Borneo, Sumatra, Java, Philippines - Geographicus - EastIndies-cary-1801.jpg

File:Antoine-François Callet - Louis XVI, roi de France et de Navarre (1754-1793), revêtu du grand costume royal en 1779 - Google Art Project.jpg


Version: unspecified
Severity: normal

Details

Reference
bz72389

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:58 AM
bzimport set Reference to bz72389.
bzimport added a subscriber: Unknown Object (MLST).

Appears to be accientally caused by f7be7e6a (Abbreviation threshold for files with long names was set to 140 for commons as a foreign repo, but kept at 160 on actual commons, thus breaking all files with a name between 140-160 bytes long)

gerritadmin wrote:

Change 168239 had a related patch set uploaded by Brian Wolff:
Partial revert f7be7e6a. Change commons abbrvThreshold back to 160.

https://gerrit.wikimedia.org/r/168239

I wonder if it would be a good idea to also make expected name mismatches give a redirect instead of an error to prevent this sort of thing from causing explosions (And allow more mobility in changing the value in the future w/o breaking hotlinkers, or old values from parser cache)

gerritadmin wrote:

Change 168239 merged by jenkins-bot:
Partial revert f7be7e6a. Change commons abbrvThreshold back to 160.

https://gerrit.wikimedia.org/r/168239

CScott deployed fix, so it should be resolved now. (Some cached pages may need to have ?action=purge done to them)

(In reply to Bawolff (Brian Wolff) from comment #1)

Appears to be accientally caused by f7be7e6a (Abbreviation threshold for
files with long names was set to 140 for commons as a foreign repo, but kept
at 160 on actual commons, thus breaking all files with a name between
140-160 bytes long)

Eventually we want to get rid of filenames in URLs completely (bug 64214). Although I suppose some form of redirect would still be needed at that point, to not break all hotlinks.

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy