Skip to content

implement Send and Sync for PyBackedStr and PyBackedBytes #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2024
Merged

implement Send and Sync for PyBackedStr and PyBackedBytes #4007

merged 1 commit into from
Mar 29, 2024

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented Mar 28, 2024 •
edited
Loading

I noticed while working on my PyO3 tutorial today that the PyBackedStr and PyBackedBytes types do not implement Send or Sync, because they have a NonNull pointer inside them.

I think it should be perfectly safe to implement Send and Sync here, because these types are immutable and the Py smart pointer is already Send and Sync.

@davidhewitt davidhewitt mentioned this pull request Mar 28, 2024
Merged
adamreichold
adamreichold approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storing NonNull<str> instead of NonNull<[u8]> is certainly a nice expansion of type safety.

@davidhewitt davidhewitt added this pull request to the merge queue Mar 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 29, 2024
@davidhewitt
Copy link
Member Author

PyPy fix can't come soon enough :)

@davidhewitt davidhewitt added this pull request to the merge queue Mar 29, 2024
Merged via the queue into PyO3:main with commit b053e83 Mar 29, 2024
@davidhewitt davidhewitt deleted the backed-send-sync branch March 29, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyAcorn LilyAcorn LilyAcorn approved these changes

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidhewitt @LilyAcorn @adamreichold
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy