Declare free-threaded support for PyModule #4588

ngoldbaum · 2024-10-01T22:49:00Z

Adds a supports_free_threaded argument to the pymodule macro and a supports_free_threaded method to PyModule.

Updates the tests and examples to mark that they support free-threading.

Removes UNSAFE_PYO3_BUILD_FREE_THREADED=1 from the build config.

ngoldbaum · 2024-10-19T23:19:39Z

Just a note that this should probably only be merged once all the "RuntimeWarning: The global interpreter lock (GIL) has been enabled to load module foo" warnings in the python tests are fixed in the free-threaded build.

ngoldbaum · 2024-10-21T23:31:16Z

Just a note that this should probably only be merged once all the "RuntimeWarning: The global interpreter lock (GIL) has been enabled to load module foo" warnings in the python tests are fixed in the free-threaded build.

This is done now and I think all the tests are passing so I'm going to move this out of draft phase and update the PR description.

tests/ui/invalid_pymodule_args.stderr

ngoldbaum · 2024-10-21T23:40:33Z

This probably needs some discussion in the new guide section on free-threading support.

pyo3-macros-backend/src/module.rs

examples/sequential/src/module.rs

pyo3-ffi/build.rs

examples/decorator/src/lib.rs

ngoldbaum · 2024-10-23T16:43:29Z

woohoo! looks like tests are passing except for the codecov issue affecting all PRs right now.

src/macros.rs

src/types/module.rs

davidhewitt

Thanks, broadly looks great to me, a bunch of various thoughts :)

examples/decorator/src/lib.rs

examples/sequential/src/module.rs

examples/string-sum/src/lib.rs

pyo3-ffi/build.rs

pyo3-ffi/src/moduleobject.rs

guide/src/free-threading.md

src/types/module.rs

tests/ui/invalid_pymodule_args.stderr

examples/maturin-starter/src/lib.rs

ngoldbaum · 2024-10-31T15:01:07Z

It occurred to me while working on something else that this PR should remove the UNSAFE_PYO3_BUILD_FREE_THREADED uses in the CI scripts a well.

EDIT: done

davidhewitt

Thanks, I think this is looking pretty much there. Just some final tidy ups...

pyo3-ffi/examples/string-sum/src/lib.rs

pyo3-macros-backend/src/module.rs

pytests/tests/test_free_threaded.py

src/types/module.rs

guide/src/free-threading.md

davidhewitt

Super, this looks ready to ship! Thanks very much for all the work here and on the rest of the freethreading PRs 🚀

ngoldbaum force-pushed the module-support branch from 6834f3f to 1bd1338 Compare October 21, 2024 18:50

ngoldbaum mentioned this pull request Oct 21, 2024

ci: run coverage for the free-threaded build #4638

Merged

ngoldbaum marked this pull request as ready for review October 21, 2024 23:31

ngoldbaum changed the title ~~WIP: declare free-threaded support in pymodule macro~~ Declare free-threaded support for PyModule Oct 21, 2024

ngoldbaum commented Oct 21, 2024

View reviewed changes

tests/ui/invalid_pymodule_args.stderr Outdated Show resolved Hide resolved

ngoldbaum commented Oct 21, 2024

View reviewed changes

pyo3-macros-backend/src/module.rs Outdated Show resolved Hide resolved

ngoldbaum mentioned this pull request Oct 21, 2024

run nox -s clippy-all against free-threaded build in CI #4639

Closed

ngoldbaum force-pushed the module-support branch from 11f2a12 to 3021c46 Compare October 22, 2024 00:41

ngoldbaum commented Oct 22, 2024

View reviewed changes

examples/sequential/src/module.rs Outdated Show resolved Hide resolved

ngoldbaum commented Oct 22, 2024

View reviewed changes

pyo3-ffi/build.rs Outdated Show resolved Hide resolved

ngoldbaum commented Oct 22, 2024

View reviewed changes

examples/decorator/src/lib.rs Outdated Show resolved Hide resolved

ngoldbaum mentioned this pull request Oct 23, 2024

Add example Cargo.toml and build.rs for exposing pyo3 cfgs #4641

Merged

ngoldbaum force-pushed the module-support branch 2 times, most recently from 599a58e to 8f86b9e Compare October 23, 2024 21:57

ngoldbaum commented Oct 23, 2024

View reviewed changes

src/macros.rs Outdated Show resolved Hide resolved

src/types/module.rs Outdated Show resolved Hide resolved

davidhewitt reviewed Oct 25, 2024

View reviewed changes

davidhewitt mentioned this pull request Oct 25, 2024

release: 0.23.0 #4651

Merged

5 tasks

mejrs reviewed Oct 25, 2024

View reviewed changes

examples/maturin-starter/src/lib.rs Outdated Show resolved Hide resolved

davidhewitt mentioned this pull request Oct 25, 2024

Opting out of freethreading support #4652

Open

ngoldbaum mentioned this pull request Oct 28, 2024

Update docs for raw FFI use #4665

Merged

ngoldbaum force-pushed the module-support branch from 28d07c0 to 39ffe29 Compare October 28, 2024 19:50

ngoldbaum force-pushed the module-support branch from 356b2ac to a6f59f3 Compare October 31, 2024 19:16

ngoldbaum added 3 commits November 4, 2024 13:14

WIP: declare free-threaded support in pymodule macro

b120d45

ignore ruff lint about unused import

5218108

eliminate gil re-enabling in pytests

1a52a05

ngoldbaum added 17 commits November 4, 2024 13:14

fix unused import in example

04a48d8

Add pyo3-build-config as a build dependency to examples that need it

d2d3cb4

add docs

9f0688d

add rust tests so coverage picks up the new code

003aa36

fix some formatting issues

1def33b

Apply cleanups

d3ca9a2

fix cargo fmt --check

c272082

revert changes to non-FFI examples

244a32c

apply David's suggestion for the guide

1868e21

link to raw FFI examples in the guide

7495e8e

fix config guards in moduleobject.rs

3fa6f52

rename supports_free_threaded to gil_used

c34853b

remove ensure_gil_enabled from pyo3-ffi/build.rs

042e2bf

update docs for PyModule::gil_used

db912bf

remove UNSAFE_PYO3_BUILD_FREE_THREADED from the CI config

371ce0c

fix merge conflict screwup

e38676c

fix nox -s test-py

f9dae80

ngoldbaum force-pushed the module-support branch from a6f59f3 to f9dae80 Compare November 4, 2024 20:26

fix guide links

bd5473c

davidhewitt reviewed Nov 4, 2024

View reviewed changes

ngoldbaum commented Nov 4, 2024

View reviewed changes

guide/src/free-threading.md Show resolved Hide resolved

ngoldbaum added 4 commits November 4, 2024 14:29

remove redundant pytest test

45ba422

fix issue with wrap_pymodule not respecting user choice for GIL support

f40dbc9

replace map.unwrap_or with map_or

1c42dbe

fix refcounting error in ffi example

ff891f6

davidhewitt approved these changes Nov 5, 2024

View reviewed changes

davidhewitt added this pull request to the merge queue Nov 5, 2024

Merged via the queue into PyO3:main with commit 76f4503 Nov 5, 2024
44 checks passed

Aequitosh mentioned this pull request Dec 3, 2024

mgr/dashboard: Simplify authentication protocol ceph/ceph#54710

Merged

Declare free-threaded support for PyModule #4588

Declare free-threaded support for PyModule #4588

Uh oh!

Conversation

ngoldbaum commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ngoldbaum commented Oct 19, 2024

Uh oh!

ngoldbaum commented Oct 21, 2024

Uh oh!

Uh oh!

ngoldbaum commented Oct 21, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ngoldbaum commented Oct 23, 2024

Uh oh!

Uh oh!

Uh oh!

davidhewitt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ngoldbaum commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidhewitt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidhewitt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

ngoldbaum commented Oct 1, 2024 •

edited

Loading

ngoldbaum commented Oct 31, 2024 •

edited

Loading