Skip to content

added abi3-py313 feature #4969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2025
Merged

added abi3-py313 feature #4969

merged 3 commits into from
Mar 18, 2025

Conversation

emmagordon
Copy link
Contributor

@emmagordon emmagordon commented Mar 11, 2025 •
edited
Loading

I found #3645 (and the linked PR #3687) whilst looking for the abi3-py313 feature, so added it as a new feature in the same way.

Let me know if you'd like an issue to link this PR to. Thanks.

UPDATE: ah, I guess (from the couple failing CI checks) that this is no longer all that's required. Apologies, but I'm on work time and therefore not able to dig into the CI failures at the moment (the msrv check is passing for me locally). I'll try to get back to this - but might be a while! I'll leave the PR here in case a quick fix with a helpful review comment.

@ngoldbaum
Copy link
Contributor

Apologies, but I'm on work time and therefore not able to dig into the CI failures at the moment (the msrv check is passing for me locally)

I'm pretty sure the failures are unrelated to this PR - I wouldn't worry too much.

@davidhewitt
Copy link
Member

Thanks for fixing this! We've made this mistake of missing out the abi3-py3x feature for new Python versions several times now; I merged main and pushed a check to noxfile.py to help avoid this again in future.

@davidhewitt davidhewitt enabled auto-merge March 18, 2025 20:47
@davidhewitt davidhewitt added this pull request to the merge queue Mar 18, 2025
Merged via the queue into PyO3:main with commit 478d08e Mar 18, 2025
48 checks passed
@emmagordon
Copy link
Contributor Author

Thanks for fixing this! We've made this mistake of missing out the abi3-py3x feature for new Python versions several times now; I merged main and pushed a check to noxfile.py to help avoid this again in future.

Great call on adding the check, thanks for following up/merging.

@ddelange
Copy link
Contributor

ddelange commented Apr 1, 2025

Hi 👋

I saw this PR was included in the latest release. What is the use of this flag? Is it to compile abi3 cp313 wheels which are compatible with e.g. cp314?

Are there any docs I can look at?

@ngoldbaum
Copy link
Contributor

Is it to compile abi3 cp313 wheels which are compatible with e.g. cp314?

Yes, you’d use this if you wanted to use the limited API, but only with Python 3.13 or newer.

Are there any docs I can look at?

Maybe https://docs.python.org/3/c-api/stable.html#limited-c-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emmagordon @ngoldbaum @davidhewitt @ddelange
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy