fix(specs): Add customSearchParameters to Variant schema, and add direction query param for GET abtests #5130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… param for GET abtests
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
|
Hey @shortcuts, would it be possible re-release the alpha client after this gets merged? Thanks in advance for your help / review! |
cdhawke
approved these changes
Jul 18, 2025
shortcuts
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
hey sorry I was already OOO at that time, I'd recommend you to set your team as codeowners here https://github.com/algolia/api-clients-automation/blob/main/CODEOWNERS so that you can go ahead with the specs change and potentially release the clients using this GitHub action https://github.com/algolia/api-clients-automation/actions/workflows/scheduled-release.yml
algolia-bot
added a commit
that referenced
this pull request
Jul 21, 2025
…ection query param for GET abtests (#5130) (generated) [skip ci] Co-authored-by: Leonardo Gavaudan <leonardogavaudan@gmail.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jul 21, 2025
…ection query param for GET abtests (generated) algolia/api-clients-automation#5130 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Leonardo Gavaudan <leonardogavaudan@gmail.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
directionforGET /abtestscustomSearchParametersin theVariantschema which is then used in theGET /abtests/response🧭 What and Why
🎟 JIRA Ticket:
Changes included:
🧪 Test