Skip to content

feat(yaml_parser): parse block sequence #6727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

vohoanglong0107
Copy link
Contributor

@vohoanglong0107 vohoanglong0107 commented Jul 6, 2025

Summary

Parse YAML block sequence in the form of

- a
- b
- c

This PR also changes the lexer's tokens emit order, now all *_END tokens must be followed by at least one NEWLINE token. This will disallow these tokens from being attached trailing tokens, as the trailing tokens attaching logic doesn't work properly with zero-width token like these

Compact forms of block sequences and mappings are also removed in this PR, as they now longer needed to be explicitly handled by the parser.

Test Plan

Added new tests for in form of YAML files containing both YAML block sequences and block mapping.

Copy link

changeset-bot bot commented Jul 6, 2025

⚠️ No Changeset found

Latest commit: 4aa06ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Parser Area: parser A-Tooling Area: internal tools labels Jul 6, 2025
Copy link

codspeed-hq bot commented Jul 6, 2025

CodSpeed Performance Report

Merging #6727 will not alter performance

Comparing vohoanglong0107:yaml-parse-sequence (4aa06ea) with main (52e36ae)

Summary

✅ 114 untouched benchmarks

@vohoanglong0107 vohoanglong0107 requested review from a team July 6, 2025 23:25
@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review July 6, 2025 23:25
Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vohoanglong0107 vohoanglong0107 merged commit 51bf430 into biomejs:main Jul 17, 2025
30 checks passed
@vohoanglong0107 vohoanglong0107 deleted the yaml-parse-sequence branch July 20, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Parser Area: parser A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy