feat(wasm): expose MemoryFileSystem via WASM API #6428
Merged
+671
−594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae191aa to
fd626c3
Compare
CodSpeed Performance ReportMerging #6428 will not alter performanceComparing Summary
|
fd626c3 to
284db91
Compare
siketyan
commented
Jun 19, 2025
| let base_dir = if cfg!(target_family = "wasm") { | ||
| PathBuf::from("/") | ||
| } else { | ||
| std::env::current_dir()? |
There was a problem hiding this comment.
std::env::current_dir() was called inside Absolutize::absolutize_from implicity and caused "not supported on this platform" error.
eebdc18 to
8688a0f
Compare
8688a0f to
7e251b5
Compare
🦋 Changeset detectedLatest commit: b9f403f The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7e251b5 to
42ce884
Compare
siketyan
commented
Jun 27, 2025
| @@ -97,7 +97,7 @@ impl MemoryFileSystem { | |||
| } | |||
|
|
|||
| /// Create or update a file in the filesystem | |||
| pub fn insert(&mut self, path: Utf8PathBuf, content: impl Into<Vec<u8>>) { | |||
| pub fn insert(&self, path: Utf8PathBuf, content: impl Into<Vec<u8>>) { | |||
There was a problem hiding this comment.
Removed excess mutability from here and the diff has many of removing mut keywords 😢
13408f9 to
ecada68
Compare
ematipico
approved these changes
Jun 28, 2025
Comment on lines
+47
to
+50
| #[wasm_bindgen(js_name = remove)] | ||
| pub fn remove(&self, path: &str) { | ||
| self.inner.remove(Utf8Path::new(path)); | ||
| } |
There was a problem hiding this comment.
Should we also export an "update" function? Genuinely asking
There was a problem hiding this comment.
I think no, we can use insert to update a file
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
MemoryFileSystemto the WASM API.Now we can access the memory filesystem from outside, insert or remove files.
As a bonus, GritQL plugins are now supported to be called on WASM builds.
Test Plan
Manually tested with playground