refactor(useSortedKeys): transfer trailing separator upon sorting #6587
Conversation
🦋 Changeset detectedLatest commit: eb541de The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #6587 will improve performances by 9.08%Comparing Summary
Benchmarks breakdown
|
|
|
||
| # Diagnostics | ||
| ``` | ||
| issue-5710.js:2:1 assist/source/organizeImports FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ |
There was a problem hiding this comment.
This is a little improvement over the previous implementation :)
There was a problem hiding this comment.
If there's an improvement, we should add a changeset for it. It's always good to tell users stuff
There was a problem hiding this comment.
This is really edgy: you have to have buggy nodes like here where specifiers are duplicated.
There was a problem hiding this comment.
I think we did this in the past, where we fixed (and emitted diagnostics) from broken nodes, rather than panicking. It's still a good improvement for the DX, even when it's an edge case. But I won't block the PR for it, it's your call :)
7db0ed5 to
9a9b2fd
Compare
Summary
Fix #6491
I moved
ComparableTokentobiome_string_caseand utilities related to separated list sorting tobiome_analyze.I am quite satisfied of these utilities that will allow us to easily implement rules for sorting separated list.
I didn't take a look at
useSortedAttributes. I left it for a future PR.We now avoid allocation on the happy path (when everything is already sorted).
Also, I improved the diagnostics, and we now emit a single diagnostic for a given object.
Test Plan
I added tests.