Skip to content

fix(lsp): add missing checks for capability dynamic registration support #6643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

skewb1k
Copy link
Contributor

@skewb1k skewb1k commented Jun 30, 2025

Some LSP capabilities were dynamically registered even if client does not support it, which does not comply with the LSP specification and not expected by clients, for example Neovim (reported in #4994).

Copy link

changeset-bot bot commented Jun 30, 2025

🦋 Changeset detected

Latest commit: d77e9a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the A-LSP Area: language server protocol label Jun 30, 2025
@skewb1k skewb1k force-pushed the fix/capabilities-dyn-registration branch from d1e0b37 to d77e9a6 Compare June 30, 2025 13:16
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you

@ematipico ematipico merged commit df15ad6 into biomejs:main Jun 30, 2025
12 checks passed
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
@skewb1k skewb1k deleted the fix/capabilities-dyn-registration branch July 1, 2025 07:19
arendjr pushed a commit that referenced this pull request Jul 1, 2025
…ort (#6643)

Co-authored-by: ematipico <602478+ematipico@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LSP Area: language server protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy