fix: do not exit process on rule crash (#19436)

fasttime · web-flow · commit d8ffdd4e51ac · 2025-02-20T14:20:05.000+01:00
* test: rule crash should not exit process

* update `@humanwhocodes/retry`
diff --git a/package.json b/package.json
@@ -108,7 +108,7 @@
     "@eslint/plugin-kit": "^0.2.5",
     "@humanfs/node": "^0.16.6",
     "@humanwhocodes/module-importer": "^1.0.1",
-    "@humanwhocodes/retry": "^0.4.1",
+    "@humanwhocodes/retry": "^0.4.2",
     "@types/estree": "^1.0.6",
     "@types/json-schema": "^7.0.15",
     "ajv": "^6.12.4",
diff --git a/tests/lib/eslint/eslint.js b/tests/lib/eslint/eslint.js
@@ -6158,6 +6158,54 @@ describe("ESLint", () => {
                 assert.strictEqual(createCallCount, 1);
             });
 
+            // https://github.com/eslint/eslint/issues/19243
+            it("should not exit the process unexpectedly after a rule crashes", async () => {
+                const cwd = getFixturePath();
+
+                /*
+                 * Mocha attaches `unhandledRejection` event handlers to the current process.
+                 * To test without global handlers, we must launch a new process.
+                 */
+                const teardown = createCustomTeardown({
+                    cwd,
+                    files: {
+                        "test.js": `
+                        const { ESLint } = require(${JSON.stringify(require.resolve("eslint"))});
+
+                        const eslint = new ESLint({
+                            flags: ${JSON.stringify(flags)},
+                            overrideConfigFile: true,
+                            plugins: {
+                                boom: {
+                                    rules: {
+                                        boom: {
+                                            create: () => ({
+                                                "*"() {
+                                                    throw "Boom!";
+                                                },
+                                            }),
+                                        }
+                                    }
+                                }
+                            },
+                            baseConfig: {
+                                rules: {
+                                    "boom/boom": "error"
+                                }
+                            }
+                        });
+
+                        eslint.lintFiles("passing.js").catch(() => { });
+                        `
+                    }
+                });
+
+                await teardown.prepare();
+                const execFile = util.promisify(require("node:child_process").execFile);
+
+                await execFile(process.execPath, ["test.js"], { cwd });
+            });
+
             describe("Error while globbing", () => {
 
                 it("should throw an error with a glob pattern if an invalid config was provided", async () => {
