fix: add `@eslint/core`, `@types/estree`, & `@types/json-schema` deps #18938

snitin315 · 2024-09-21T05:47:47Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix #18936

Mention @types/estree, @eslint/core, & @types/json-schema as optional peer dependencies and mention to install them in the docs

Is there anything you'd like reviewers to focus on?

No

netlify · 2024-09-21T05:48:04Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`0eecbf0`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/66f192eca4c62d0008734da2

docs/src/use/configure/configuration-files.md

fasttime · 2024-09-21T12:22:57Z

knip.jsonc

+                // Optional peer dependencies used inside types
+                "@eslint/core",
+                "@types/estree",
+                "@types/json-schema"


I actually agree with knip that these should not be optional peerDependencies. Optional peers are not installed by default by npm install, they only instruct npm to raise an error if another package tries to install those dependencies in a version that is out of the specified range. I'm not sure this is even desirable in this case.

These should be optional because only a subset of users who want types would be using them.

I agree with @fasttime, I think @eslint/core, @types/estree and @types/json-schema should just be dependencies. It especially makes sense for @types/estree and @types/json-schema since they were previously dependencies of @types/eslint which has now been merged with eslint.

For users it would be easier if ESLint depended on those packages as regular dependencies, but if we are going to ask them to install the packages manually in the docs, then we don't need to add anything to our own package.json. We could also include those packages as optional peer dependencies with version "*" so that they don't cause version conflicts like we did for jiti.

I'm running ESLint v9.11.0, and I'm having TS related issues because I need to manually install @eslint/core. I think it'll make more sense if the packages we are directly deriving types from to be dependencies. Since we can't really throw a runtime error to let them know to install them like we did with jiti.

Peer dependencies are automatically installed with npm install. Is there a reason we'd prefer dependencies over that?

@nzakas Peer dependencies can clash between different modules and are harder to get updated through eg. Renovate and Dependabot – only reason to add these as peer dependencies is if they are considered too heavy to ship with ESLint by standard, making it an optional opt in for those who want to use types

We can make these direct dependencies the only downside is that it would increase some bundle size, but I think it should be fine because in most cases ESlint would be installed as a dev dependency only. Similarly, packages like webpack and webpack-dev-serve have also mentioned @types/* directly in dependencies.

voxpelli · 2024-09-23T10:20:34Z

Suggestion:

Change this:

eslint/lib/types/index.d.ts

Lines 28 to 30 in 2738322

    
           import * as ESTree from "estree"; 
        
           import { Language } from "@eslint/core"; 
        
           import { JSONSchema4 } from "json-schema";

To:

// @ts-ignore
import * as ESTree from "estree";
// @ts-ignore
import { Language } from "@eslint/core";
// @ts-ignore
import { JSONSchema4 } from "json-schema";

That way the types will be included if the types are available and else it will gracefully degrade and still work.

…karound for eslint/eslint#18938

See eslint/eslint#18938

nzakas · 2024-09-23T14:20:15Z

docs/src/use/configure/configuration-files.md

@@ -511,14 +511,14 @@ You need to enable this feature through the `unstable_ts_config` feature flag:
 npx eslint --flag unstable_ts_config
 ```

-For Deno and Bun, TypeScript configuration files are natively supported; for Node.js, you must install the optional dev dependency [`jiti`](https://github.com/unjs/jiti) in your project (this dependency is not automatically installed by ESLint):
+For Deno and Bun, TypeScript configuration files are natively supported; for Node.js, you must install the following optional dev dependencies in your project (these dependencies are not automatically installed by ESLint):


npm automatically installs peer dependencies. If we're adding these packages as peer dependencies, then I don't think we need to ask people to install them here?

The suggestion in this PR is to add them as optionals:

"peerDependenciesMeta": { "jiti": { "optional": true }, "@types/estree": { "optional": true }, "@eslint/core": { "optional": true }, "@types/json-schema": { "optional": true } },

So that means npm wouldn't install them automatically?

And then wouldn't we also need to install these on Deno and Bun?

@nzakas Exactly, only way to make truly optional dependencies, unlike optionalDependencies

From npm docs:

allows peer dependencies to be marked as optional. Npm will not automatically install optional peer dependencies

Whereas optionalDependencies are only through npm install --omit=optional or when:

you would like npm to proceed if it cannot be found or fails to install

And then wouldn't we also need to install these on Deno and Bun?

Yes, as mentioned by #18938 (comment) this is not tied to TypeScript config files but rather to everyone that run type checks that relies on eslint – which can happen on js-files, ts-files and possibly also eg. VSCode IntelliSense

nzakas · 2024-09-23T14:21:23Z

knip.jsonc

+                // Optional peer dependencies used inside types
+                "@eslint/core",
+                "@types/estree",
+                "@types/json-schema"


Peer dependencies are automatically installed with npm install. Is there a reason we'd prefer dependencies over that?

nzakas · 2024-09-23T14:35:17Z

I think asking people to manually install multiple packages like this is a lousy experience. They'll need to do it not just to use the TypeScript config files but also if they're building on top of the API.

So, I think I agree with @aryaemami59 that we should add these as dependencies to avoid this mess.

snitin315 · 2024-09-23T14:47:05Z

Yes, I'll update the PR and add them to dependencies. #18938 (comment)

package.json

nzakas · 2024-09-23T15:00:13Z

Can we also add an integration test for eslint-visitor-keys? The CI for that package is currently failing:
https://github.com/eslint/js/actions/runs/10970936801/job/30465408211

This can be added to the types-integration.yml workflow.

nzakas · 2024-09-23T15:15:43Z

Looks like the integration test is failing.

JoshuaKGoldberg · 2024-09-23T15:16:12Z

👍 from me on adding as dependencies rather than dev* or peer*. Since there's no way to mark a types dependency from a runtime dependency, I don't know of a better way to get them to be installed automatically for users who need them.

A nice side effect of enforcing types packages be installed is that everyone who uses an IDE with TypeScript enabled will get nice autocompletions even in their JS files.

Note that this is different from the situation in eslint/rewrite#104 (comment), I think. Over in @eslint/compat, it's expected that folks are already installing eslint & other related packages. The peerDependency there should just be to ensure getting the proper versions of packages that were already going to be installed, as I understand it.

voxpelli · 2024-09-23T15:17:39Z

The one alternative would be to add them as dev dependencies and use a bundler to bundle the needed types into the final type file – but that adds a needless build step

snitin315 · 2024-09-23T15:21:24Z

Looks like the integration test is failing.

@nzakas yes, npm install is failing I think that's because eslint/js repo still points to an older version of eslint in package json

snitin315 · 2024-09-24T05:01:50Z

Ah, I can see now from eslint/js#629 that "@types/estree": "^0.0.51", should also be removed. And we're generally using pretty old dev deps in eslint-visitor-keys.

Yes, that's because of the old types, I'll update it once the patch version is released.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@eslint/js](https://eslint.org) ([source](https://github.com/eslint/eslint/tree/HEAD/packages/js)) | devDependencies | minor | [`9.10.0` -> `9.13.0`](https://renovatebot.com/diffs/npm/@eslint%2fjs/9.10.0/9.13.0) | --- ### Release Notes <details> <summary>eslint/eslint (@eslint/js)</summary> ### [`v9.13.0`](https://github.com/eslint/eslint/releases/tag/v9.13.0) [Compare Source](eslint/eslint@v9.12.0...v9.13.0) #### Features - [`381c32b`](eslint/eslint@381c32b) feat: Allow languages to provide `defaultLanguageOptions` ([#19003](eslint/eslint#19003)) (Milos Djermanovic) - [`bf723bd`](eslint/eslint@bf723bd) feat: Improve eslintrc warning message ([#19023](eslint/eslint#19023)) (Milos Djermanovic) - [`1def4cd`](eslint/eslint@1def4cd) feat: drop support for jiti v1.21 ([#18996](eslint/eslint#18996)) (Francesco Trotta) - [`f879be2`](eslint/eslint@f879be2) feat: export `ESLint.defaultConfig` ([#18983](eslint/eslint#18983)) (Nitin Kumar) #### Bug Fixes - [`78836d4`](eslint/eslint@78836d4) fix: update the `complexity` rule type ([#19027](eslint/eslint#19027)) (Nitin Kumar) - [`064c8b6`](eslint/eslint@064c8b6) fix: update rule types ([#18925](eslint/eslint#18925)) (Nitin Kumar) #### Documentation - [`abdbfa8`](eslint/eslint@abdbfa8) docs: mark `LintMessage#nodeType` as deprecated ([#19019](eslint/eslint#19019)) (Nitin Kumar) - [`19e68d3`](eslint/eslint@19e68d3) docs: update deprecated rules type definitions ([#19018](eslint/eslint#19018)) (Nitin Kumar) - [`7dd402d`](eslint/eslint@7dd402d) docs: Update examples of passing multiple values to a CLI option ([#19006](eslint/eslint#19006)) (Milos Djermanovic) - [`5dcbc51`](eslint/eslint@5dcbc51) docs: Add example with side-effect imports to no-restricted-imports ([#18997](eslint/eslint#18997)) (Milos Djermanovic) - [`1ee87ca`](eslint/eslint@1ee87ca) docs: Update README (GitHub Actions Bot) - [`2c3dbdc`](eslint/eslint@2c3dbdc) docs: Use prerendered sponsors for README ([#18988](eslint/eslint#18988)) (Milos Djermanovic) #### Chores - [`68d2d9d`](eslint/eslint@68d2d9d) chore: upgrade to `@eslint/js@9.13.0` and `@eslint/core@^0.7.0` ([#19034](eslint/eslint#19034)) (Francesco Trotta) - [`2211f0a`](eslint/eslint@2211f0a) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`c7abaef`](eslint/eslint@c7abaef) perf: using Node.js compile cache ([#19012](eslint/eslint#19012)) (唯然) - [`1d7c077`](eslint/eslint@1d7c077) chore: add pkg.type "commonjs" ([#19011](eslint/eslint#19011)) (唯然) - [`468e3bd`](eslint/eslint@468e3bd) test: fix `ESLint` tests ([#19021](eslint/eslint#19021)) (Francesco Trotta) - [`ed4635f`](eslint/eslint@ed4635f) ci: upgrade knip@5.32.0 ([#18992](eslint/eslint#18992)) (Milos Djermanovic) - [`efad767`](eslint/eslint@efad767) chore: remove unused ignore dependency ([#18993](eslint/eslint#18993)) (Amaresh S M) ### [`v9.12.0`](https://github.com/eslint/eslint/releases/tag/v9.12.0) [Compare Source](eslint/eslint@v9.11.1...v9.12.0) #### Features - [`5a6a053`](eslint/eslint@5a6a053) feat: update to `jiti` v2 ([#18954](eslint/eslint#18954)) (Arya Emami) - [`17a07fb`](eslint/eslint@17a07fb) feat: Hooks for test cases (RuleTester) ([#18771](eslint/eslint#18771)) (Anna Bocharova) - [`2ff0e51`](eslint/eslint@2ff0e51) feat: Implement alternate config lookup ([#18742](eslint/eslint#18742)) (Nicholas C. Zakas) - [`2d17453`](eslint/eslint@2d17453) feat: Implement modified cyclomatic complexity ([#18896](eslint/eslint#18896)) (Dmitry Pashkevich) #### Bug Fixes - [`ea380ca`](eslint/eslint@ea380ca) fix: Upgrade retry to avoid EMFILE errors ([#18986](eslint/eslint#18986)) (Nicholas C. Zakas) - [`fdd6319`](eslint/eslint@fdd6319) fix: Issues with type definitions ([#18940](eslint/eslint#18940)) (Arya Emami) #### Documentation - [`ecbd522`](eslint/eslint@ecbd522) docs: Mention code explorer ([#18978](eslint/eslint#18978)) (Nicholas C. Zakas) - [`7ea4ecc`](eslint/eslint@7ea4ecc) docs: Clarifying the Use of Meta Objects ([#18697](eslint/eslint#18697)) (Amaresh S M) - [`d3e4b2e`](eslint/eslint@d3e4b2e) docs: Clarify how to exclude `.js` files ([#18976](eslint/eslint#18976)) (Milos Djermanovic) - [`57232ff`](eslint/eslint@57232ff) docs: Mention plugin-kit in language docs ([#18973](eslint/eslint#18973)) (Nicholas C. Zakas) - [`b80ed00`](eslint/eslint@b80ed00) docs: Update README (GitHub Actions Bot) - [`cb69ab3`](eslint/eslint@cb69ab3) docs: Update README (GitHub Actions Bot) - [`7fb0d95`](eslint/eslint@7fb0d95) docs: Update README (GitHub Actions Bot) - [`493348a`](eslint/eslint@493348a) docs: Update README (GitHub Actions Bot) - [`87a582c`](eslint/eslint@87a582c) docs: fix typo in `id-match` rule ([#18944](eslint/eslint#18944)) (Jay) #### Chores - [`555aafd`](eslint/eslint@555aafd) chore: upgrade to `@eslint/js@9.12.0` ([#18987](eslint/eslint#18987)) (Francesco Trotta) - [`873ae60`](eslint/eslint@873ae60) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`d0a5414`](eslint/eslint@d0a5414) refactor: replace strip-ansi with native module ([#18982](eslint/eslint#18982)) (Cristopher) - [`b827029`](eslint/eslint@b827029) chore: Enable JSON5 linting ([#18979](eslint/eslint#18979)) (Milos Djermanovic) - [`8f55ca2`](eslint/eslint@8f55ca2) chore: Upgrade espree, eslint-visitor-keys, eslint-scope ([#18962](eslint/eslint#18962)) (Nicholas C. Zakas) - [`c1a2725`](eslint/eslint@c1a2725) chore: update dependency mocha to ^10.7.3 ([#18945](eslint/eslint#18945)) (Milos Djermanovic) ### [`v9.11.1`](https://github.com/eslint/eslint/releases/tag/v9.11.1) [Compare Source](eslint/eslint@v9.11.0...v9.11.1) #### Bug Fixes - [`20fd916`](eslint/eslint@20fd916) fix: add `@eslint/core`, `@types/estree`, & `@types/json-schema` deps ([#18938](eslint/eslint#18938)) (Nitin Kumar) - [`2738322`](eslint/eslint@2738322) fix: add missing types for `require-atomic-updates` rule ([#18937](eslint/eslint#18937)) (Kristóf Poduszló) - [`d71ff30`](eslint/eslint@d71ff30) fix: add missing types for `object-shorthand` rule ([#18935](eslint/eslint#18935)) (Kristóf Poduszló) - [`561cadc`](eslint/eslint@561cadc) fix: add missing types for `no-unsafe-negation` rule ([#18932](eslint/eslint#18932)) (Kristóf Poduszló) - [`8843656`](eslint/eslint@8843656) fix: add missing types for `no-underscore-dangle` rule ([#18931](eslint/eslint#18931)) (Kristóf Poduszló) - [`92cde5c`](eslint/eslint@92cde5c) fix: add missing types for `no-shadow` rule ([#18930](eslint/eslint#18930)) (Kristóf Poduszló) - [`b3cbe11`](eslint/eslint@b3cbe11) fix: add missing types for `no-sequences` rule ([#18929](eslint/eslint#18929)) (Kristóf Poduszló) - [`976f77f`](eslint/eslint@976f77f) fix: add missing types for `no-unused-expressions` rule ([#18933](eslint/eslint#18933)) (Kristóf Poduszló) #### Documentation - [`3eff709`](eslint/eslint@3eff709) docs: replace deprecated `Linter.FlatConfig` type with `Linter.Config` ([#18941](eslint/eslint#18941)) (Carlos Meira) #### Chores - [`df4a859`](eslint/eslint@df4a859) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@9](https://github.com/9).11.1 ([#18943](eslint/eslint#18943)) (Milos Djermanovic) - [`36d8095`](eslint/eslint@36d8095) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) ### [`v9.11.0`](https://github.com/eslint/eslint/releases/tag/v9.11.0) [Compare Source](eslint/eslint@v9.10.0...v9.11.0) #### Features - [`ec30c73`](eslint/eslint@ec30c73) feat: add "eslint/universal" to export `Linter` ([#18883](eslint/eslint#18883)) (唯然) - [`c591da6`](eslint/eslint@c591da6) feat: Add language to types ([#18917](eslint/eslint#18917)) (Nicholas C. Zakas) - [`492eb8f`](eslint/eslint@492eb8f) feat: limit the name given to `ImportSpecifier` in `id-length` ([#18861](eslint/eslint#18861)) (Tanuj Kanti) - [`19c6856`](eslint/eslint@19c6856) feat: Add `no-useless-constructor` suggestion ([#18799](eslint/eslint#18799)) (Jordan Thomson) - [`a48f8c2`](eslint/eslint@a48f8c2) feat: add type `FormatterFunction`, update `LoadedFormatter` ([#18872](eslint/eslint#18872)) (Francesco Trotta) #### Bug Fixes - [`5e5f39b`](eslint/eslint@5e5f39b) fix: add missing types for `no-restricted-exports` rule ([#18914](eslint/eslint#18914)) (Kristóf Poduszló) - [`8f630eb`](eslint/eslint@8f630eb) fix: add missing types for `no-param-reassign` options ([#18906](eslint/eslint#18906)) (Kristóf Poduszló) - [`d715781`](eslint/eslint@d715781) fix: add missing types for `no-extra-boolean-cast` options ([#18902](eslint/eslint#18902)) (Kristóf Poduszló) - [`2de5742`](eslint/eslint@2de5742) fix: add missing types for `no-misleading-character-class` options ([#18905](eslint/eslint#18905)) (Kristóf Poduszló) - [`c153084`](eslint/eslint@c153084) fix: add missing types for `no-implicit-coercion` options ([#18903](eslint/eslint#18903)) (Kristóf Poduszló) - [`fa11b2e`](eslint/eslint@fa11b2e) fix: add missing types for `no-empty-function` options ([#18901](eslint/eslint#18901)) (Kristóf Poduszló) - [`a0deed1`](eslint/eslint@a0deed1) fix: add missing types for `camelcase` options ([#18897](eslint/eslint#18897)) (Kristóf Poduszló) #### Documentation - [`e4e5709`](eslint/eslint@e4e5709) docs: correct `prefer-object-has-own` type definition comment ([#18924](eslint/eslint#18924)) (Nitin Kumar) - [`91cbd18`](eslint/eslint@91cbd18) docs: add unicode abbreviations in no-irregular-whitespace rule ([#18894](eslint/eslint#18894)) (Alix Royere) - [`59cfc0f`](eslint/eslint@59cfc0f) docs: clarify `resultsMeta` in `LoadedFormatter` type ([#18881](eslint/eslint#18881)) (Milos Djermanovic) - [`adcc50d`](eslint/eslint@adcc50d) docs: Update README (GitHub Actions Bot) - [`4edac1a`](eslint/eslint@4edac1a) docs: Update README (GitHub Actions Bot) #### Build Related - [`959d360`](eslint/eslint@959d360) build: Support updates to previous major versions ([#18871](eslint/eslint#18871)) (Milos Djermanovic) #### Chores - [`ca21a64`](eslint/eslint@ca21a64) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@9](https://github.com/9).11.0 ([#18927](eslint/eslint#18927)) (Milos Djermanovic) - [`a10f90a`](eslint/eslint@a10f90a) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`e4e02cc`](eslint/eslint@e4e02cc) refactor: Extract processor logic into ProcessorService ([#18818](eslint/eslint#18818)) (Nicholas C. Zakas) - [`6d4484d`](eslint/eslint@6d4484d) chore: updates for v8.57.1 release (Jenkins) - [`71f37c5`](eslint/eslint@71f37c5) refactor: use optional chaining when validating config rules ([#18893](eslint/eslint#18893)) (lucasrmendonca) - [`2c2805f`](eslint/eslint@2c2805f) chore: Add PR note to all templates ([#18892](eslint/eslint#18892)) (Nicholas C. Zakas) - [`7b852ce`](eslint/eslint@7b852ce) refactor: use `Directive` class from `@eslint/plugin-kit` ([#18884](eslint/eslint#18884)) (Milos Djermanovic) - [`d594ddd`](eslint/eslint@d594ddd) chore: update dependency [@eslint/core](https://github.com/eslint/core) to ^0.6.0 ([#18863](eslint/eslint#18863)) (renovate\[bot]) - [`78b2421`](eslint/eslint@78b2421) chore: Update change.yml ([#18882](eslint/eslint#18882)) (Nicholas C. Zakas) - [`a416f0a`](eslint/eslint@a416f0a) chore: enable `$ExpectType` comments in .ts files ([#18869](eslint/eslint#18869)) (Francesco Trotta) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/231 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

snitin315 requested a review from a team as a code owner September 21, 2024 05:47

eslint-github-bot bot added the bug ESLint is working incorrectly label Sep 21, 2024

snitin315 force-pushed the fix/update-peer-deps branch from 938dd39 to 8c19eef Compare September 21, 2024 05:56

fasttime reviewed Sep 21, 2024

View reviewed changes

docs/src/use/configure/configuration-files.md Outdated Show resolved Hide resolved

fasttime reviewed Sep 21, 2024

View reviewed changes

AaronMoat mentioned this pull request Sep 22, 2024

ESLint 9, flat config migration seek-oss/skuba#1537

Merged

AaronMoat added a commit to seek-oss/skuba that referenced this pull request Sep 23, 2024

Update eslint-config-seek, and add @eslint/core as a temporary(?) wor…

e0c7435

…karound for eslint/eslint#18938

voxpelli added a commit to voxpelli/eslint-plugin-react that referenced this pull request Sep 23, 2024

Add missing dependencies

183def6

See eslint/eslint#18938

voxpelli mentioned this pull request Sep 23, 2024

Generate type declarations from JSDoc jsx-eslint/eslint-plugin-react#3830

Merged

nzakas requested a review from JoshuaKGoldberg September 23, 2024 14:17

nzakas reviewed Sep 23, 2024

View reviewed changes

snitin315 changed the title ~~fix: update peerDependencies & peerDependenciesMeta fields~~ fix: add @eslint/core, @types/estree, & @types/json-schema as dependencies Sep 23, 2024

snitin315 changed the title ~~fix: add @eslint/core, @types/estree, & @types/json-schema as dependencies~~ fix: add @eslint/core, @types/estree, & @types/json-schema deps Sep 23, 2024

fix: add @eslint/core, @types/estree, & @types/json-schema deps

88f4bac

snitin315 force-pushed the fix/update-peer-deps branch from 8ba2392 to 88f4bac Compare September 23, 2024 14:52

eslint deleted a comment from eslint-github-bot bot Sep 23, 2024

fix: use caret in deps

9c1180b

voxpelli reviewed Sep 23, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

snitin315 added 2 commits September 23, 2024 20:30

chore: sore dependencies

4f85e06

ci: add types check for eslint-visitor-keys

6204b01

github-actions bot added the github actions label Sep 23, 2024

mdjermanovic deleted the fix/update-peer-deps branch September 23, 2024 18:36

snitin315 mentioned this pull request Sep 29, 2024

feat: remove @types/eslint package DefinitelyTyped/DefinitelyTyped#70735

Merged

9 tasks

snitin315 mentioned this pull request Oct 11, 2024

feat: add types for the @eslint/js package #19010

Merged

1 task

Loonz206 mentioned this pull request Oct 16, 2024

[Snyk] Upgrade eslint from 9.9.1 to 9.11.1 Loonz206/todoredux#349

Merged

This was referenced Oct 28, 2024

[Snyk] Upgrade eslint from 9.3.0 to 9.12.0 tygyh/godot#11

Closed

[Snyk] Upgrade @eslint/js from 9.10.0 to 9.12.0 tygyh/godot#12

Closed

lholmquist mentioned this pull request Oct 28, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.12.0 nodeshift/kube-service-bindings#241

Closed

ekmixon mentioned this pull request Oct 28, 2024

[Snyk] Upgrade eslint from 6.8.0 to 9.12.0 ekmixon/aquasecurity-cloudsploit#150

Open

This was referenced Oct 29, 2024

[Snyk] Upgrade eslint from 8.57.1 to 9.12.0 nerdy-tech-com-gitub/images#7

Open

[Snyk] Upgrade eslint from 6.8.0 to 9.12.0 nerdy-tech-com-gitub/foreman#2

Open

Bonniemarie216 mentioned this pull request Oct 29, 2024

[Snyk] Upgrade @eslint/js from 9.11.1 to 9.12.0 Bonniemarie216/eslint#1

Open

Loonz206 mentioned this pull request Oct 30, 2024

[Snyk] Upgrade eslint from 9.9.1 to 9.12.0 Loonz206/todoredux#355

Open

lholmquist mentioned this pull request Oct 30, 2024

[Snyk] Upgrade eslint from 8.51.0 to 9.12.0 nodeshift/opossum#899

Closed

erossignon mentioned this pull request Oct 31, 2024

[Snyk] Upgrade eslint from 9.11.1 to 9.12.0 node-opcua/node-opcua-crypto#55

Closed

lholmquist mentioned this pull request Oct 31, 2024

[Snyk] Upgrade eslint from 8.46.0 to 9.12.0 nodeshift/faas-js-runtime#369

Closed

leoo1992 mentioned this pull request Oct 31, 2024

[Snyk] Upgrade eslint from 9.11.1 to 9.12.0 leoo1992/sistema_ponto#90

Open

zntb mentioned this pull request Nov 1, 2024

[Snyk] Upgrade eslint from 9.10.0 to 9.12.0 zntb/nextjs-template#70

Closed

This was referenced Nov 1, 2024

[Snyk] Upgrade @eslint/js from 9.11.1 to 9.12.0 qdraw/starsky#1794

Merged

[Snyk] Upgrade eslint from 9.11.1 to 9.12.0 qdraw/starsky#1795

Closed

lholmquist mentioned this pull request Nov 4, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.12.0 nodeshift/kube-service-bindings#244

Closed

sahilbhelkar mentioned this pull request Nov 5, 2024

[Snyk] Upgrade eslint from 9.0.0 to 9.12.0 sahilbhelkar/space#4

Open

nerdy-tech-com-gitub mentioned this pull request Nov 10, 2024

[Snyk] Upgrade eslint from 8.57.1 to 9.13.0 nerdy-tech-com-gitub/tailwindcss#7

Open

Uh oh!

fix: add @eslint/core, @types/estree, & @types/json-schema deps #18938

fix: add @eslint/core, @types/estree, & @types/json-schema deps #18938

Uh oh!

Conversation

snitin315 commented Sep 21, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify bot commented Sep 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint canceled.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

voxpelli Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

voxpelli commented Sep 23, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nzakas commented Sep 23, 2024

Uh oh!

snitin315 commented Sep 23, 2024

Uh oh!

Uh oh!

nzakas commented Sep 23, 2024

Uh oh!

nzakas commented Sep 23, 2024

Uh oh!

JoshuaKGoldberg commented Sep 23, 2024

Uh oh!

voxpelli commented Sep 23, 2024

Uh oh!

snitin315 commented Sep 23, 2024

Uh oh!

snitin315 commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

fix: add `@eslint/core`, `@types/estree`, & `@types/json-schema` deps #18938

fix: add `@eslint/core`, `@types/estree`, & `@types/json-schema` deps #18938

netlify bot commented Sep 21, 2024 •

edited

Loading

voxpelli Sep 23, 2024 •

edited

Loading

snitin315 commented Sep 24, 2024 •

edited

Loading