perf: optimize text-table by replacing regex with trimEnd
#19061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
nzakas
reviewed
Oct 28, 2024
JoshuaKGoldberg
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Functional changes LGTM - it's easier to review when they're so close to the original! 🙂
But, something like half the file is dead code from over a decade ago. It feels odd to me to include so much of that in ESLint. Proposal: how about treating this as a fork of text-table and removing the portions that are never used?
|
I have resolved all the comments. Ready for a re-review. |
JoshuaKGoldberg
requested changes
Nov 1, 2024
mdjermanovic
requested changes
Nov 2, 2024
|
@mdjermanovic Good catch! Fixed in 89efc43 |
mdjermanovic
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @nzakas and @JoshuaKGoldberg to verify.
nzakas
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
LGTM. Waiting for @JoshuaKGoldberg to verify before merging.
JoshuaKGoldberg
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Performance improvements
What changes did you make? (Give an overview)
Fix #18709
Is there anything you'd like reviewers to focus on?
I disabled some lint rules to avoid unwanted refactors in 3rd party code.