Skip to content

docs: add missing backticks to no-unneeded-ternary #19222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Dec 6, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Hello,

I've added missing backticks to no-unneeded-ternary.md.

I believe that ! and defaultAssignment option should be wrapped in backticks.

Is there anything you'd like reviewers to focus on?

@lumirlumir lumirlumir requested a review from a team as a code owner December 6, 2024 08:15
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Dec 6, 2024
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit afed667
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6752b2aacbd8120008e4242a
😎 Deploy Preview https://deploy-preview-19222--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit e4a0753
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6752b2b6d17be90008f9e535
😎 Deploy Preview https://deploy-preview-19222--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic changed the title docs: add missing backticks to no-unneeded-ternary.md docs: add missing backticks to no-unneeded-ternary Dec 6, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 85998d1 into eslint:main Dec 6, 2024
27 checks passed
@lumirlumir lumirlumir deleted the docs-add-missing-backticks-to-no-unneeded-ternary branch December 6, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy