Skip to content

docs: replace var with let and const in rule example #19434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Replaced var with let and const in following rule examples

no-continue
no-magic-numbers
no-labels
no-sequences
unicode-bom

Is there anything you'd like reviewers to focus on?

refs #19240

similar as #19335

@Tanujkanti4441 Tanujkanti4441 requested a review from a team as a code owner February 19, 2025 08:39
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Feb 19, 2025
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit cf6d410
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67b598b0ae4f9e000869d772
😎 Deploy Preview https://deploy-preview-19434--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 19, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 80b0485 into eslint:main Feb 19, 2025
31 checks passed
@Tanujkanti4441 Tanujkanti4441 deleted the replace-vars branch February 19, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy