Skip to content

fix: do not exit process on rule crash #19436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

fix: do not exit process on rule crash #19436

merged 2 commits into from
Feb 20, 2025

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Feb 19, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #19243

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Feb 19, 2025
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit b52c9e0
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67b6be3685ffa800089cad05
😎 Deploy Preview https://deploy-preview-19436--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fasttime fasttime changed the title test: rule crash should not exit process fix: do not exit process on rule crash Feb 20, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Feb 20, 2025
@fasttime fasttime added accepted There is consensus among the team that this change meets the criteria for inclusion dependencies Pull requests that update a dependency file and removed chore This change is not user-facing labels Feb 20, 2025
@fasttime fasttime marked this pull request as ready for review February 20, 2025 05:40
@fasttime fasttime requested a review from a team as a code owner February 20, 2025 05:40
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit d8ffdd4 into main Feb 20, 2025
30 checks passed
@mdjermanovic mdjermanovic deleted the issue19243 branch February 20, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly dependencies Pull requests that update a dependency file
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: Unexpected process exit on next tick when rule throws error since 9.14
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy