feat: Export defineConfig, globalIgnores #19487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdjermanovic
reviewed
Mar 7, 2025
| @@ -72,15 +72,17 @@ This ensures that pnpm installs dependencies in a way that is more compatible wi | |||
| You can configure rules in your `eslint.config.js` files as in this example: | |||
|
|
|||
| ```js | |||
| export default [ | |||
| import { defineConfig } from "eslint/config"; | |||
There was a problem hiding this comment.
Since eslint is still CJS, should we maybe rather use default imports (e.g., import config from "eslint/config";) in ESM config examples as they're guaranteed to work?
There was a problem hiding this comment.
At least locally, this seems to work fine as-is. (Node v22.9.0)
mdjermanovic
reviewed
Mar 7, 2025
mdjermanovic
reviewed
Mar 7, 2025
mdjermanovic
reviewed
Mar 7, 2025
mdjermanovic
reviewed
Mar 7, 2025
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
1 task
1 task
1 task
kdeldycke
added a commit
to kdeldycke/workflows
that referenced
this pull request
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
/configentrypoint on the package to exportdefineConfigandglobalIgnores/configentrypointeslint.config.jsto usedefineConfigandglobalIgnoresdocs/src/use/configure/combine-configs.md: Updated all examples to usedefineConfigfor defining configurations, ensuring consistency and clarity in the documentation. [1] [2] [3]docs/src/use/configure/configuration-files.md: Revised multiple sections to incorporatedefineConfig, including examples for applying rules, specifying files, and handling ignores. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]README.md: Updated the example configuration to usedefineConfigfor better compatibility and standardization.fixes #19116
Is there anything you'd like reviewers to focus on?
Did I miss any important docs?