feat: add sourceCode.isGlobalReference(node) method
#19695
Merged
+730
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2e0c495 to
18aeca0
Compare
snitin315
commented
May 11, 2025
fisker
reviewed
May 11, 2025
4 tasks
fisker
reviewed
May 21, 2025
Co-authored-by: fisker Cheung <lionkay@gmail.com>
nzakas
reviewed
May 21, 2025
nzakas
reviewed
May 22, 2025
Comment on lines
3659
to
3660
| it("should handle function parameters and shadowed globals", () => { | ||
| const code = "function test(param, console) { param; console; }"; |
There was a problem hiding this comment.
There are no shadowed globals in this test. (console is not an ES global).
There was a problem hiding this comment.
Changed it to NaN.
|
We should probably also update types: Line 180 in 72d16e3 |
|
@snitin315 please check the merge conflicts. |
mdjermanovic
approved these changes
Jun 1, 2025
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @nzakas to verify changes after previous approval.
nzakas
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fix #19651
Is there anything you'd like reviewers to focus on?
#19695 (comment)