refactor: SafeEmitter -> SourceCodeVisitor #19708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
ec670bc to
4acbab9
Compare
mdjermanovic
reviewed
Jun 2, 2025
mdjermanovic
reviewed
Jun 2, 2025
mdjermanovic
reviewed
Jun 3, 2025
mdjermanovic
reviewed
Jun 3, 2025
lib/linter/source-code-traverser.js
Outdated
Comment on lines
199
to
202
| const isAnyTypeSelectorMoreSpecific = | ||
| hasMoreAnyTypeSelectors && | ||
| hasMoreNodeTypeSelectors && | ||
| anyTypeSelector.compare(nodeTypeSelector) < 0; |
There was a problem hiding this comment.
I believe this should be isAnyTypeSelectorLessSpecific, not More.
There was a problem hiding this comment.
Thanks. I've found this specificity concept difficult to wrap my brain around. In CSS, higher specificity takes priority but here lower specificity does.
a3ce474 to
586c617
Compare
mdjermanovic
reviewed
Jun 4, 2025
mdjermanovic
reviewed
Jun 4, 2025
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This further refactors the traversal logic, moving it closer to being able to support asynchronous rules.
SafeEmitterwithSourceCodeVisitor. This is a more accurate representation of what we want to happen (for a given name, retrieve functions to execute) vs. emitting events with multiple listeners. This will also make it easier to implement async rules in the future.SourceCodeTraverserso thattraverseSync()is responsible for calling functions instead ofESQueryHelper.ESQueryHelperto only match and return selectors instead of emitting events.Depends on #19679
Refs #18787
Is there anything you'd like reviewers to focus on?