Skip to content

docs: replace var with const in rule examples #19469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

Tanujkanti4441
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 commented Feb 28, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

replaced var with const in following rule examples"

no-implicit-coercion
no-inline-comments
no-invalid-this
no-multi-str
no-new-func

Is there anything you'd like reviewers to focus on?

Refs #19240

@Tanujkanti4441 Tanujkanti4441 requested a review from a team as a code owner February 28, 2025 17:11
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Feb 28, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Feb 28, 2025
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 6242c1f
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67c1ee30c3b04900080d22c2
😎 Deploy Preview https://deploy-preview-19469--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 28, 2025
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks. Waiting for 2nd approval.

@amareshsm amareshsm moved this from Needs Triage to Second Review Needed in Triage Feb 28, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 2f386ad into eslint:main Mar 1, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Mar 1, 2025
@Tanujkanti4441 Tanujkanti4441 deleted the replace-var branch March 1, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy