Skip to content

fix: improve message for no-console suggestions #19483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Mar 6, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #19477

What changes did you make? (Give an overview)

Added a new message without placeholders to the no-console rule. The new message will be used for suggestions to remove method calls on console when the method name is computed.

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 6, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Mar 6, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Mar 6, 2025
Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 2c5000a
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67c98335ff2fab00085ba6ba

@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 6, 2025
@fasttime fasttime marked this pull request as ready for review March 6, 2025 11:20
@fasttime fasttime requested a review from a team as a code owner March 6, 2025 11:20
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 19c0127 into main Mar 6, 2025
30 checks passed
@mdjermanovic mdjermanovic deleted the issue19477 branch March 6, 2025 11:47
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: no-console bad suggestion message with non-literal method names
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy