Skip to content

fix: allow RuleTester to test files inside node_modules/ #19499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Mar 11, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Stop applying default ignores to RuleTester.
Fixes #19471

Is there anything you'd like reviewers to focus on?

No

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Mar 11, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Mar 11, 2025
@github-actions github-actions bot added the core Relates to ESLint's core APIs and features label Mar 11, 2025
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 0ce9cb9
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67d04c42a7152600085cb837

@fisker fisker mentioned this pull request Mar 11, 2025
1 task
@fisker fisker marked this pull request as ready for review March 11, 2025 07:25
@fisker fisker requested a review from a team as a code owner March 11, 2025 07:25
@fisker fisker changed the title fix: allow test files inside node_modules/ fix: allow test files inside node_modules/ in RuleTester Mar 11, 2025
@fisker fisker changed the title fix: allow test files inside node_modules/ in RuleTester fix: allow RuleTester to test files inside node_modules/ Mar 11, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Mar 11, 2025
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Mar 11, 2025
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would like @nzakas to verify.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Mar 11, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit f4e9c5f into eslint:main Mar 11, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Mar 11, 2025
@fisker fisker deleted the 19471 branch March 11, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly contributor pool core Relates to ESLint's core APIs and features
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: Can't test cases that filename contains node_modules/
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy