chore: add type tests for core package
#137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
commented
Dec 2, 2024
nzakas
reviewed
Dec 3, 2024
nzakas
reviewed
Dec 3, 2024
| TraversalStep, | ||
| } from "@eslint/core"; | ||
|
|
||
| interface TestLanguageOptions extends LanguageOptions { |
There was a problem hiding this comment.
Can we add some separators in this file? It's not clear to me which of these is intended to test something vs. which are just data needed for a test later in the file.
There was a problem hiding this comment.
Most of the definitions use implements or extends to test the exported types, but some of them are also used later as test helpers for other types, like TestSourceCode in createSourceCode. I tried to separate definitions by usage in 0705730.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add type tests.
What changes did you make? (Give an overview)
Add basic type tests for the
corepackage and update the CI build to run the type tests.Related Issues
Is there anything you'd like reviewers to focus on?