feat(person): use fake patterns for jobTitle (#2528)

matthewmayer · web-flow · commit b40ad45ad3cc · 2023-11-07T20:59:19.000Z
diff --git a/src/definitions/person.ts b/src/definitions/person.ts
@@ -41,6 +41,8 @@ export type PersonDefinition = LocaleEntry<{
 
   title: PersonTitleDefinition;
 
+  job_title_pattern: string[];
+
   western_zodiac_sign: string[];
 }>;
 
diff --git a/src/locales/en/person/index.ts b/src/locales/en/person/index.ts
@@ -11,6 +11,7 @@ import female_middle_name from './female_middle_name';
 import female_prefix from './female_prefix';
 import first_name from './first_name';
 import gender from './gender';
+import job_title_pattern from './job_title_pattern';
 import last_name from './last_name';
 import last_name_pattern from './last_name_pattern';
 import male_first_name from './male_first_name';
@@ -33,6 +34,7 @@ const person: PersonDefinition = {
   female_prefix,
   first_name,
   gender,
+  job_title_pattern,
   last_name,
   last_name_pattern,
   male_first_name,
diff --git a/src/locales/en/person/job_title_pattern.ts b/src/locales/en/person/job_title_pattern.ts
@@ -0,0 +1,3 @@
+export default [
+  '{{person.jobDescriptor}} {{person.jobArea}} {{person.jobType}}',
+];
diff --git a/src/locales/es/person/index.ts b/src/locales/es/person/index.ts
@@ -6,6 +6,7 @@ import type { PersonDefinition } from '../../..';
 import female_first_name from './female_first_name';
 import female_prefix from './female_prefix';
 import first_name from './first_name';
+import job_title_pattern from './job_title_pattern';
 import last_name from './last_name';
 import last_name_pattern from './last_name_pattern';
 import male_first_name from './male_first_name';
@@ -19,6 +20,7 @@ const person: PersonDefinition = {
   female_first_name,
   female_prefix,
   first_name,
+  job_title_pattern,
   last_name,
   last_name_pattern,
   male_first_name,
diff --git a/src/locales/es/person/job_title_pattern.ts b/src/locales/es/person/job_title_pattern.ts
@@ -0,0 +1,3 @@
+export default [
+  '{{person.jobType}} de {{person.jobArea}} {{person.jobDescriptor}}',
+];
diff --git a/src/modules/person/index.ts b/src/modules/person/index.ts
@@ -336,7 +336,9 @@ export class PersonModule extends ModuleBase {
    * @since 8.0.0
    */
   jobTitle(): string {
-    return `${this.jobDescriptor()} ${this.jobArea()} ${this.jobType()}`;
+    return this.faker.helpers.fake(
+      this.faker.definitions.person.job_title_pattern
+    );
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default [`
	`2`	`+ '{{person.jobDescriptor}} {{person.jobArea}} {{person.jobType}}',`
	`3`	`+];`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default [`
	`2`	`+ '{{person.jobType}} de {{person.jobArea}} {{person.jobDescriptor}}',`
	`3`	`+];`