Skip to content

test: mv skip-reply-send from tap #6094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 15, 2025

Conversation

jean-michelet
Copy link
Member

No description provided.

@jean-michelet jean-michelet added the test Issue or pr related to our testing infrastructure. label May 1, 2025
@jean-michelet jean-michelet requested review from climba03003 and a team and removed request for climba03003 May 1, 2025 14:39
@Fdawgs Fdawgs requested a review from Copilot May 2, 2025 19:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the test suite for "skip reply send" functionality, switching from the tap framework to Node’s built-in test module. Key changes include:

  • Replacing require('tap') with require('node:test') and adding the describe block.
  • Converting tests to async functions with the use of await with app.inject.
  • Updating assertions from t.equal/t.fail to t.assert.strictEqual/t.assert.fail for consistency.

@Eomm Eomm merged commit df9ea6f into fastify:main May 15, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issue or pr related to our testing infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy