fix: check if ProcessPromise is settled on kill and abort
#1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Jul 10, 2025
- Tests pass
- Appropriate changes to README are included in PR
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds guards to ProcessPromise methods to throw errors when aborting or killing after settlement and includes tests for these scenarios.
- Added
isSettled()checks inabortandkillto prevent calls on settled processes - Introduced tests in
test/core.test.jsto verify errors for too-late abort/kill and too-early kill - Updated CJS build output and bumped size limits in
.size-limit.json
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/core.test.js | Added tests for abort/kill error conditions (too late/too early) |
| src/core.ts | Inserted isSettled() guards in abort and kill methods |
| build/core.cjs | Mirrored isSettled() guards in compiled CJS output |
| .size-limit.json | Increased bundle size thresholds |
Comments suppressed due to low confidence (2)
test/core.test.js:971
- [nitpick] Consider adding a test for calling
p.abort()before the process is created to ensure it throws the expected "Trying to abort a process without creating one." error.
test('abort signal is transmittable through pipe', async () => {
src/core.ts:453
- The
killmethod declares aPromise<void>return type but doesn't return the promise from the helper; addreturn kill(this.child.pid, signal)to propagate it.
return $.kill(this.child.pid, signal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.