Remove -plain suffix from Grails Plugin artifacts
#347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 3, 2024
jdaugherty
approved these changes
Nov 4, 2024
| } | ||
| project.tasks.named(JavaPlugin.JAR_TASK_NAME, Jar) { | ||
| it.enabled = true | ||
| it.archiveClassifier.set('') // Remove '-plain' suffix from jar file name |
There was a problem hiding this comment.
So this will impact any grails plugin (which is probably a very good thing) - @jamesfredley started a google document to gather upgrade gotchas. @codeconsole moved that document to here: https://github.com/grails/grails-core/blob/7.0.x/UPGRADE7.md Can you add a bullet point documenting this change for plugin authors?
There was a problem hiding this comment.
So this will impact any grails plugin
Yes, any project that applies the org.grails.grails-plugin gradle plugin will be impacted.
Can you add a bullet point documenting this change for plugin authors?
Here is an PR for the Grails 7 gotchas: apache/grails-core#13825
codeconsole
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.