grpc-js: add await/async on method that return promise #2376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add await/async on method that return promise to ensure that the order of message (and of the end of stream) are preserved
|
|
|
Hello, I'm not sur why the windows build failed. Is it related to the modification of |
|
Don't worry about it. That's an old failure that's unrelated to this change. |
|
Hello, Can I afford to ask what is the rest of the process on the PullRequest? (Are we still waiting for something from me to continue) |
|
I'm sorry about the delay. I'm not waiting on anything from you, I've just been focused on other things. |
murgatroid99
approved these changes
Mar 6, 2023
|
I published this in version 1.8.12 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add await/async on method that return promise to ensure that the order of message (and of the end of stream) are preserved
The goal is to fix the ticket #2375 where the end of stream can arrive before last messages and the message can be lost.