Move mockito to 4.11.0 and handle byte buddy consistently as well as properly define its agent in argLine for surefire #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions were mixed due to assertj usage. This fixes usage up through java 21 in usage. In current usage the byte buddy agent is dynamically added, it will now be defined up front for tests thus solving future jdk deprecation usage and possible removal now.
jlerbsc
reviewed
Nov 28, 2023
| @@ -409,6 +411,16 @@ | |||
| <version>4.11.0</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>net.bytebuddy</groupId> | |||
There was a problem hiding this comment.
Why are you adding this dependency?
|
It's used by assertj and mockito. If not added it resolves mixed usage of the main byte buddy library and the agent which fails the build. This ensures it does not regress from expectations.
Not sure if you use eclipse or not but it's m2e resolution easily shows this. For testing you can look at the open pull requests that already fail.
The agent is added in this way as newer jdks will emit issues with it being auto loaded which will be blocked in the future.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: jean pierre Lerbscher ***@***.***>
Sent: Tuesday, November 28, 2023 3:05:19 AM
To: javaparser/javaparser ***@***.***>
Cc: Jeremy Landis ***@***.***>; Author ***@***.***>
Subject: Re: [javaparser/javaparser] Move mockito to 4.11.0 and handle byte buddy consistently as well as properly define its agent in argLine for surefire (PR #4228)
@jlerbsc commented on this pull request.
________________________________
In pom.xml<#4228 (comment)>:
@@ -409,6 +411,16 @@
<version>4.11.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>net.bytebuddy</groupId>
Why are you adding this dependency?
—
Reply to this email directly, view it on GitHub<#4228 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI47DBWY7TBH2WSAJV3YGWLL7AVCNFSM6AAAAAA72JZL32VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJSGI3TCNBXGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.