Fix expressions in the body of switch expression entries (Issue 4440) #4446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4446 +/- ##
=========================================
Coverage 51.999% 51.999%
=========================================
Files 507 507
Lines 28654 28654
Branches 4969 4969
=========================================
Hits 14900 14900
Misses 11685 11685
Partials 2069 2069
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4440
I introduced this bug in #4364 to fix an issue with the LPP by expecting a
StatementExpressioninstead of anExpressionin the body of a switch statement. This did fix the semi-colon issue I had, but I didn't consider the fact thatStatementExpressionisn't just a wrapper around anExpression, but actually a proper subset. This meant that a lot of expression types were not supported anymore.This PR changes this back. I didn't run into the same LPP issue again, so I suspect I just didn't understand how sequences should be parenthesized or something like that before.