Skip to content

#4664 remove misleading javadoc #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

verhasi
Copy link
Contributor

@verhasi verhasi commented Jan 26, 2025

Fixes #4664. It is time to remove the misleading Javadoc after a decade.

@jlerbsc
Copy link
Collaborator

jlerbsc commented Jan 27, 2025

Thank you for your contribution.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.120%. Comparing base (f5bdce5) to head (2cc3892).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #4666   +/-   ##
=========================================
  Coverage   58.120%   58.120%           
=========================================
  Files          508       508           
  Lines        29776     29776           
  Branches      5251      5251           
=========================================
  Hits         17306     17306           
  Misses       10332     10332           
  Partials      2138      2138           
Flag Coverage Δ
AlsoSlowTests 58.120% <ø> (ø)
javaparser-core 58.120% <ø> (ø)
javaparser-symbol-solver 58.120% <ø> (ø)
jdk-10 58.087% <ø> (ø)
jdk-11 58.087% <ø> (ø)
jdk-12 58.087% <ø> (ø)
jdk-13 58.087% <ø> (ø)
jdk-14 58.087% <ø> (ø)
jdk-15 58.087% <ø> (ø)
jdk-16 58.087% <ø> (ø)
jdk-17 58.087% <ø> (ø)
jdk-18 58.087% <ø> (ø)
jdk-8 58.089% <ø> (ø)
jdk-9 58.083% <ø> (ø)
macos-latest 58.110% <ø> (ø)
ubuntu-latest 58.110% <ø> (ø)
windows-latest 58.097% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/main/java/com/github/javaparser/JavaParser.java 87.654% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8dd751...2cc3892. Read the comment docs.

@jlerbsc jlerbsc merged commit 25cd16b into javaparser:master Jan 27, 2025
35 checks passed
@verhasi verhasi deleted the #4664_remove_misleading_javadoc branch March 10, 2025 07:07
@jlerbsc jlerbsc added this to the 3.26.4 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading Javadoc in com.github.javaparser.JavaParser.java
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy