refactor(bananass): minor tweaks and cleanup #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces minor refactoring and cleanup across the codebase. The changes focus on standardizing function signatures by adding default parameters, enforcing ESLint rules for consistent code style, and enhancing functionality with a new constant for output file extensions, along with some documentation and translation tweaks.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bananass/src/core/constants.js | Added DEFAULT_OUT_FILE_EXTENSION for file output names |
| packages/bananass/src/commands/index.js | Inserted ESLint rules for import and key sorting |
| packages/bananass/src/commands/bananass-run/run.js | Updated jsdoc and default parameter for configObject |
| packages/bananass/src/commands/bananass-repo/repo.js | Updated jsdoc for configObject default parameter |
| packages/bananass/src/commands/bananass-open/open.js | Updated jsdoc for configObject default parameter |
| packages/bananass/src/commands/bananass-info/info.js | Updated jsdoc for configObject default parameter |
| packages/bananass/src/commands/bananass-home/home.js | Updated jsdoc for configObject default parameter |
| packages/bananass/src/commands/bananass-discussion/discussion.js | Updated jsdoc for configObject default parameter |
| packages/bananass/src/commands/bananass-build/build.js | Adjusted documentation and output filename construction |
| packages/bananass/src/commands/bananass-bug/bug.js | Updated jsdoc for configObject default parameter |
| SECURITY.md | Corrected translation for clarity |
|
Labels have been automatically applied based on the Conventional Commits specification.🏷️ |
Bundle ReportChanges will decrease total bundle size by 698.38kB (-46.43%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: websites-vitepress-esmAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 162 162
Lines 9664 9664
Branches 16 16
=======================================
Hits 9502 9502
Misses 162 162
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
lumirlumir
added a commit
that referenced
this pull request
Apr 24, 2025
….0-canary.3` (`prerelease`) (#362) ## Release Information: `v0.1.0-canary.3` New release of `lumirlumir/npm-bananass` has arrived! 🎉 This PR bumps the package versions from `v0.1.0-canary.2` to `v0.1.0-canary.3` (`prerelease`). See [Actions](https://github.com/lumirlumir/npm-bananass/actions/runs/14634205891) for more details. | Info | Value | | ----------- | -------------------------- | | Repository | `lumirlumir/npm-bananass` | | SEMVER | `prerelease` | | Pre ID | `canary` | | Short SHA | cf78531 | | Old Version | `v0.1.0-canary.2` | | New Version | `v0.1.0-canary.3` | <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### ✨ Features * feat(bananass): support `Array.prototype.toSorted` transpilation using custom babel plugin by @lumirlumir in #350 * feat(bananass): support `Array.prototype.toReversed` transpilation using custom babel plugin by @lumirlumir in #351 * feat(bananass): support `Object.hasOwn` transpilation using custom babel plugin by @lumirlumir in #356 * feat(bananass): add support computed bracket form for `toSorted` and `toReversed` by @lumirlumir in #357 ### 🐛 Bug Fixes * fix(eslint-config-bananass): enhance JSDoc template and update types in `index.js` by @lumirlumir in #338 * fix(bananass): replace esbuild loader with babel loader for js code bundling by @lumirlumir in #344 * fix(bananass): drop esbuild-loader and create e2e tests for bananass build with mts module system by @lumirlumir in #360 * fix(bananass): fix `.cts` module interop and create e2e tests for bananass build with `cts` module system by @lumirlumir in #361 ### 🧰 Chores * chore(*): install `@types/node` and update `lint-staged` configuration by @lumirlumir in #337 ### 📝 Documentation * docs(*): update `README.md`, `README.en.md`, and `CONTRIBUTING.md` by @lumirlumir in #336 ### ♻️ Code Refactoring * refactor(bananass): minor tweaks and cleanup by @lumirlumir in #343 * refactor(bananass): remove unused cli commands (`random`, `testcase`) and cleanup by @lumirlumir in #359 ### 🧪 Tests * test(*): create e2e tests for bananass-build with `cjs` module system by @lumirlumir in #341 * test(tests-e2e): create e2e tests for bananass build with `mjs` module system by @lumirlumir in #342 * test(*): create integration tests for package json `engines.node` field by @lumirlumir in #358 ### ⬆️ Dependency Updates * chore(deps): bump the typescript-eslint group across 2 directories with 2 updates by @dependabot in #331 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.5.1 to 1.5.2 by @dependabot in #332 * chore(deps): bump open from 10.1.0 to 10.1.1 by @dependabot in #334 * chore(deps): bump the next group across 2 directories with 1 update by @dependabot in #340 * chore(deps): bump webpack from 5.99.5 to 5.99.6 by @dependabot in #345 * chore(deps-dev): bump eslint from 9.24.0 to 9.25.0 by @dependabot in #347 * chore(deps): bump the typescript-eslint group across 2 directories with 2 updates by @dependabot in #352 * chore(deps-dev): bump eslint from 9.25.0 to 9.25.1 by @dependabot in #353 **Full Changelog**: v0.1.0-canary.2...v0.1.0-canary.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates across multiple files, focusing on improving code consistency, adding functionality for file extensions, and refining documentation. Below is a categorized summary of the most important changes:
Code Consistency Improvements:
packages/bananass/src/commandsto use a default parameter[configObject = dco]forConfigObject, ensuring consistent function signatures. [1] [2] [3] [4] [5] [6] [7]packages/bananass/src/commands/index.jsto enforce consistent code style.Functional Enhancements:
DEFAULT_OUT_FILE_EXTENSIONinpackages/bananass/src/core/constants.jsto define the default output file extension as.cjs.build.jsfile to useDEFAULT_OUT_FILE_EXTENSIONfor output filenames, replacing hardcoded.cjsvalues. [1] [2]Documentation Updates:
@fileoverviewinbuild.jsto include Babel as part of the build process, reflecting the current functionality.Minor Text Adjustments:
SECURITY.mdby replacing "종속성" with "의존성" for better readability.