refactor(bananass): remove unused clean command and cleanup
#364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase by removing the unused clean command and its related configurations, while also improving build configuration constants and standardizing CLI descriptions.
- Removed the clean command implementation, tests, and configuration references.
- Introduced NODE_VERSION_BAEKJOON and NODE_VERSION_CODEFORCES constants to replace hardcoded Node.js version strings.
- Standardized and improved CLI command descriptions and minor code organization.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bananass/src/core/structs/index.js | Removed import and export of ConfigObjectClean. |
| packages/bananass/src/core/structs/config-object/config-object.js | Removed clean property from the config object struct. |
| packages/bananass/src/core/structs/config-object-clean/* | Deleted the clean command struct and its tests. |
| packages/bananass/src/core/fs/find-root-dir/find-root-dir.js | Removed the "TODO: Async" comment to clean up the file. |
| packages/bananass/src/core/constants.js | Added NODE_VERSION_BAEKJOON and NODE_VERSION_CODEFORCES constants. |
| packages/bananass/src/core/conf/default-config-object/default-config-object.js | Removed clean property and updated code regions for clarity. |
| packages/bananass/src/core/cli/descriptions.js | Updated build command description to include Babel in the bundling process. |
| packages/bananass/src/commands/bananass-build/build.js | Replaced hardcoded Node.js version strings with NODE_VERSION_BAEKJOON. |
| packages/bananass/src/cli/* | Removed clean command usage and updated CLI command descriptions. |
| packages/bananass-utils-console/src/theme/theme.js & icons/icons.js | Made minor comment and parameter type improvements. |
|
Labels have been automatically applied based on the Conventional Commits specification.🏷️ |
Bundle ReportChanges will decrease total bundle size by 698.17kB (-46.42%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: websites-vitepress-esmAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 98.33% 98.32% -0.02%
==========================================
Files 163 160 -3
Lines 9759 9689 -70
Branches 16 16
==========================================
- Hits 9597 9527 -70
Misses 162 162
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This was referenced Apr 24, 2025
lumirlumir
added a commit
that referenced
this pull request
Apr 25, 2025
….0-canary.4` (`prerelease`) (#369) ## Release Information: `v0.1.0-canary.4` New release of `lumirlumir/npm-bananass` has arrived! 🎉 This PR bumps the package versions from `v0.1.0-canary.3` to `v0.1.0-canary.4` (`prerelease`). See [Actions](https://github.com/lumirlumir/npm-bananass/actions/runs/14666575875) for more details. | Info | Value | | ----------- | -------------------------- | | Repository | `lumirlumir/npm-bananass` | | SEMVER | `prerelease` | | Pre ID | `canary` | | Short SHA | 07d7535 | | Old Version | `v0.1.0-canary.3` | | New Version | `v0.1.0-canary.4` | <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### 🐛 Bug Fixes * fix(create-bananass): `.gitignore` file is ignored when publish to npm by @lumirlumir in #368 ### 🔄 Continuous Integrations * ci(*): create `test-cross-platform.yml` by @lumirlumir in #363 ### ♻️ Code Refactoring * refactor(bananass): remove unused `clean` command and cleanup by @lumirlumir in #364 * refactor(*): standardize variable names from `inputFile` to `inputStr` across examples and templates by @lumirlumir in #365 * refactor(create-bananass): update templates by @lumirlumir in #339 ### 🧪 Tests * test(bananass): create unit test for bananass build by @lumirlumir in #366 ### ⬆️ Dependency Updates * chore(deps-dev): bump @types/node from 22.14.1 to 22.15.0 by @dependabot in #367 **Full Changelog**: v0.1.0-canary.3...v0.1.0-canary.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across the codebase, focusing on removing the
cleancommand and its related configurations, improving descriptions and constants, and making minor enhancements to the CLI commands. Below is a breakdown of the most important changes:Removal of the
cleanCommand and Related Configurations:cleancommand implementation and its references frompackages/bananass/src/cli.jsandpackages/bananass/src/cli/index.js. ([[1]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-6544fc29ddb1c7332552c44ae9262c59f8067412edbd9d71bbfe3edd7472813dL17),[[2]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-6544fc29ddb1c7332552c44ae9262c59f8067412edbd9d71bbfe3edd7472813dL37),[[3]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-c9e0cfc980e6dc61abd041c44f2a2caafdfff35f9554d653ff592f72b8d30aceL5),[[4]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-c9e0cfc980e6dc61abd041c44f2a2caafdfff35f9554d653ff592f72b8d30aceL21))ConfigObjectCleanstruct, its test file, and all references to it from the configuration and struct files. ([[1]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-b3ebadf4e124d8df99ea8d8a854bed6a4aedf341d0ed7a8ebbc96b5f888fc1a5L1-L35),[[2]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-2aef8dafde43ec7527494e562b6da86a83b857f3b083a8f427e737b4426a5ffcL1-L34),[[3]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-7c9403cc68d155c53420fdee20c90330221ea889accdeacb7b660eef9ad3b1b8L1-L3),[[4]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-2d21c40c41e4bb1a28834919b113aef08fc70cdba082052bbcf8add32f0688c1L17),[[5]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-2d21c40c41e4bb1a28834919b113aef08fc70cdba082052bbcf8add32f0688c1L57),[[6]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-31769e506a0388c47f59f4387672cb97c89bc5a112be2176ef09e4938ee4ac0bL19),[[7]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-31769e506a0388c47f59f4387672cb97c89bc5a112be2176ef09e4938ee4ac0bL51))clean-related properties. ([[1]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-52a8798a5e892009d2bf6b96aaff12cc552d06b6a08c3338dacfcfb2f15d6b89L25),[[2]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-52a8798a5e892009d2bf6b96aaff12cc552d06b6a08c3338dacfcfb2f15d6b89L69-L71),[[3]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-52a8798a5e892009d2bf6b96aaff12cc552d06b6a08c3338dacfcfb2f15d6b89L117))Improvements to Build Configuration:
NODE_VERSION_BAEKJOONandNODE_VERSION_CODEFORCESconstants for better maintainability and replaced hardcoded Node.js version strings in the build configuration. ([[1]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-5b3f690c580caae1e82d3789dd6e78d9b694ac24acc51e672b297b524521fda4R28),[[2]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-5b3f690c580caae1e82d3789dd6e78d9b694ac24acc51e672b297b524521fda4L52-R60),[[3]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-5b3f690c580caae1e82d3789dd6e78d9b694ac24acc51e672b297b524521fda4L201-R202),[[4]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-97d6046c52dcaa9f59ecd0bc5a1ed48d3a91d2c8159901b86ba0b4932b532886R72-R76))[packages/bananass/src/core/cli/descriptions.jsL18-R18](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-4779ca37913f14f5aec15ce530617d866fc03de73d6a32a61264fbc8bdef8a77L18-R18))CLI Enhancements:
create) to theaddcommand and improved its description formatting. ([packages/bananass/src/cli/bananass-add.jsL29-R32](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-7ffec22a0ec92721fc993bfc6e2a84921061a2af373ea0616ad30beb086e4ec6L29-R32))[[1]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-a5d8a9e06f32b0ff0b266a32af4efc57b670308bd39d3b9a671624ee1cf6a12bL29-R29),[[2]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-a3766741b1280e4c5fd966fa079d8dfe45c2015024400fac2911123805b7bfe9L29-R29),[[3]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-dbd28d7982676e2657a1cae96931ff4fc6b6aaa77f6f0ac058f75dcd0558c690L29-R29))Minor Refactoring and Cleanup:
choosefunction to allow arrays of strings in addition to strings. ([packages/bananass-utils-console/src/icons/icons.jsL27-R28](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-d3f16eb3ff3fa7e044b861f681f7554eca8a0d838ebe6ef5e26e2adcdb008683L27-R28))[[1]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-52a8798a5e892009d2bf6b96aaff12cc552d06b6a08c3338dacfcfb2f15d6b89L41-R40),[[2]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-52a8798a5e892009d2bf6b96aaff12cc552d06b6a08c3338dacfcfb2f15d6b89L55-R56),[[3]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-52a8798a5e892009d2bf6b96aaff12cc552d06b6a08c3338dacfcfb2f15d6b89R99-R100),[[4]](https://github.com/lumirlumir/npm-bananass/pull/364/files#diff-aed2769c5bf3d27e1aa5d4b258ebffc32608a930d0f9f6a9d4c31e6416de2122L5-L6))