-
-
Notifications
You must be signed in to change notification settings - Fork 1
docs(websites-vitepress): cleanup and update documentation #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the Korean documentation for the Banana Framework by clarifying Node.js compatibility, refining installation instructions, and improving the explanation for problem 2754.
- Updated Node.js compatibility range and installation steps with clear CLI instructions.
- Enhanced the problem-solving explanation for problem 2754 with detailed mapping strategies and input trimming usage.
- Made minor text adjustments in the "Before Getting Started" section for improved readability.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
websites/vitepress/ko/solutions/baekjoon/2754.md | Improved explanation for mapping grades and handling input, with removal of placeholder content. |
websites/vitepress/ko/get-started/installation.md | Updated Node.js compatibility info and enhanced CLI installation instructions with interactive examples. |
websites/vitepress/ko/get-started/before-getting-started.md | Minor text adjustment to clarify the description of problem-solving approaches. |
Bundle ReportChanges will decrease total bundle size by 28.81kB (-1.1%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: websites-vitepress-esmAssets Changed:
Files in
Files in
Files in
Files in
|
Labels have been automatically applied based on the Conventional Commits specification.🏷️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 97.30% 97.30%
=======================================
Files 195 195
Lines 11125 11125
Branches 28 28
=======================================
Hits 10825 10825
Misses 300 300 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
….0` (`patch`) (#437) ## Release Information: `v0.1.0` New release of `lumirlumir/npm-bananass` has arrived! 🎉 This PR bumps the package versions from `v0.1.0-canary.6` to `v0.1.0` (`patch`). See [Actions](https://github.com/lumirlumir/npm-bananass/actions/runs/14977582819) for more details. | Info | Value | | ----------- | -------------------------- | | Repository | `lumirlumir/npm-bananass` | | SEMVER | `patch` | | Pre ID | `canary` | | Short SHA | fe675c7 | | Old Version | `v0.1.0-canary.6` | | New Version | `v0.1.0` | <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### 💥 BREAKING CHANGES * chore(*)!: drop support for Node.js 23 by @lumirlumir in #425 ### 📝 Documentation * docs(*): create more examples and solutions by @lumirlumir in #418 * docs(websites-vitepress): fix the ordering of solution files in sidebar by @lumirlumir in #424 * docs(websites-vitepress): complete `quick-start.md` by @lumirlumir in #426 * docs(*): add example for BOJ Problem 30802 by @sukjuhong in #427 * docs(websites-vitepress): cleanup and update documentation by @lumirlumir in #429 * docs(*): add example for BOJ Problem 28702 (FizzBuzz) by @sukjuhong in #433 * docs(websites-vitepress): cleanup documentation for a beta release by @lumirlumir in #436 ### ♻️ Code Refactoring * refactor(*): remove `.js` extension in `describe` block by @sukjuhong in #422 * refactor(bananass): remove `lint` command and consolidate with `build` by @lumirlumir in #434 * refactor(bananass): cleanup `run` command by @lumirlumir in #435 ### ⬆️ Dependency Updates * chore(deps): bump globals from 16.0.0 to 16.1.0 by @dependabot in #419 * chore(deps-dev): bump @types/node from 22.15.16 to 22.15.17 by @dependabot in #420 * chore(deps): bump eslint-plugin-n from 17.17.0 to 17.18.0 by @dependabot in #430 * chore(deps-dev): bump lint-staged from 15.5.2 to 16.0.0 by @dependabot in #431 **Full Changelog**: v0.1.0-canary.6...v0.1.0
This pull request includes updates to the Korean documentation for the Banana Framework, focusing on improving clarity, updating compatibility information, and enhancing instructions for users. Key changes include updates to Node.js compatibility, enhancements to installation instructions, and improvements to problem-solving explanations.
Documentation Updates
Node.js Compatibility
^20.18.0 || ^22.3.0 || >= 24.0.0
. This ensures users have the latest and most accurate information on supported versions.Installation Instructions
create-bananass
setup guide with additional instructions, including how to handle prompts during the installation process and details about configuration options. Added a link to thecreate-bananass
CLI documentation for further reference. [1] [2]Problem-Solving Explanations
Map
, orswitch
statements for mapping grades to scores. Added a note on the importance of usingtrim()
to handle input with trailing whitespace.Minor Text Adjustments
Removal of Placeholder Content