Skip to content

docs(websites-vitepress): cleanup and update documentation #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025

Conversation

lumirlumir
Copy link
Owner

This pull request includes updates to the Korean documentation for the Banana Framework, focusing on improving clarity, updating compatibility information, and enhancing instructions for users. Key changes include updates to Node.js compatibility, enhancements to installation instructions, and improvements to problem-solving explanations.

Documentation Updates

Node.js Compatibility

  • Updated the Node.js version compatibility range for the Banana Framework to include ^20.18.0 || ^22.3.0 || >= 24.0.0. This ensures users have the latest and most accurate information on supported versions.

Installation Instructions

  • Enhanced the create-bananass setup guide with additional instructions, including how to handle prompts during the installation process and details about configuration options. Added a link to the create-bananass CLI documentation for further reference. [1] [2]

Problem-Solving Explanations

  • Improved the explanation for solving problem 2754 on Baekjoon by detailing the use of JavaScript objects, Map, or switch statements for mapping grades to scores. Added a note on the importance of using trim() to handle input with trailing whitespace.

Minor Text Adjustments

  • Refined phrasing in the "Getting Started" and "Before Getting Started" sections for better readability and consistency. [1] [2]

Removal of Placeholder Content

  • Removed a placeholder comment from the problem 2754 solution documentation to reflect the finalized content.

@Copilot Copilot AI review requested due to automatic review settings May 11, 2025 13:38
Copy link

vercel bot commented May 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
npm-bananass-websites-vitepress ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 1:38pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
npm-bananass-websites-eslint-config-bananass ⬜️ Skipped (Inspect) May 11, 2025 1:38pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the Korean documentation for the Banana Framework by clarifying Node.js compatibility, refining installation instructions, and improving the explanation for problem 2754.

  • Updated Node.js compatibility range and installation steps with clear CLI instructions.
  • Enhanced the problem-solving explanation for problem 2754 with detailed mapping strategies and input trimming usage.
  • Made minor text adjustments in the "Before Getting Started" section for improved readability.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
websites/vitepress/ko/solutions/baekjoon/2754.md Improved explanation for mapping grades and handling input, with removal of placeholder content.
websites/vitepress/ko/get-started/installation.md Updated Node.js compatibility info and enhanced CLI installation instructions with interactive examples.
websites/vitepress/ko/get-started/before-getting-started.md Minor text adjustment to clarify the description of problem-solving approaches.

Copy link

codecov bot commented May 11, 2025

Bundle Report

Changes will decrease total bundle size by 28.81kB (-1.1%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
websites-vitepress-esm 2.26MB -28.81kB (-1.26%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: websites-vitepress-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
@localSearchIndexroot.*.js -8.07kB 111.96kB -6.72%
solutions_baekjoon_2754.*.js 475 bytes 47.0kB 1.02%
get-started_installation.*.js 12.29kB 23.36kB 111.02% ⚠️
get-started_before-getting-started.*.js 6 bytes 17.81kB 0.03%
apis_eslint-config-bananass.*.js -33.51kB 17.48kB -65.71%

Files in solutions_baekjoon_2754.*.js:

  • ./ko/solutions/baekjoon/2754.md → Total Size: 47.63kB

Files in get-started_installation.*.js:

  • ./ko/get-started/installation.md → Total Size: 21.19kB

Files in get-started_before-getting-started.*.js:

  • ./ko/get-started/before-getting-started.md → Total Size: 12.72kB

Files in apis_eslint-config-bananass.*.js:

  • ./ko/apis/eslint-config-bananass.md → Total Size: 16.56kB

@lumirlumir lumirlumir changed the title docs(website-vitepress): cleanup and update documentation docs(websites-vitepress): cleanup and update documentation May 11, 2025
@github-actions github-actions bot added 🏷️ scope: websites-vitepress Auto-generated label based on Conventional Commits specification for GitHub release notes 🏷️ type: docs Auto-generated label based on Conventional Commits specification for GitHub release notes labels May 11, 2025
Copy link

Labels have been automatically applied based on the Conventional Commits specification.🏷️

Copy link

codecov bot commented May 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (3f390b9) to head (bd5a593).

@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files         195      195           
  Lines       11125    11125           
  Branches       28       28           
=======================================
  Hits        10825    10825           
  Misses        300      300           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f390b9...bd5a593. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lumirlumir lumirlumir merged commit 6846f96 into main May 11, 2025
22 of 23 checks passed
@lumirlumir lumirlumir deleted the docs-cleanup-documentation branch May 11, 2025 13:42
lumirlumir added a commit that referenced this pull request May 12, 2025
….0` (`patch`) (#437)

## Release Information: `v0.1.0`

New release of `lumirlumir/npm-bananass` has arrived! 🎉

This PR bumps the package versions from `v0.1.0-canary.6` to `v0.1.0`
(`patch`).

See
[Actions](https://github.com/lumirlumir/npm-bananass/actions/runs/14977582819)
for more details.

| Info        | Value                      |
| ----------- | -------------------------- |
| Repository  | `lumirlumir/npm-bananass` |
| SEMVER      | `patch`     |
| Pre ID      | `canary`      |
| Short SHA   | fe675c7       |
| Old Version | `v0.1.0-canary.6`  |
| New Version | `v0.1.0`  |

<!-- Release notes generated using configuration in .github/release.yml
at main -->

## What's Changed
### 💥 BREAKING CHANGES
* chore(*)!: drop support for Node.js 23 by @lumirlumir in
#425
### 📝 Documentation
* docs(*): create more examples and solutions by @lumirlumir in
#418
* docs(websites-vitepress): fix the ordering of solution files in
sidebar by @lumirlumir in
#424
* docs(websites-vitepress): complete `quick-start.md` by @lumirlumir in
#426
* docs(*): add example for BOJ Problem 30802 by @sukjuhong in
#427
* docs(websites-vitepress): cleanup and update documentation by
@lumirlumir in #429
* docs(*): add example for BOJ Problem 28702 (FizzBuzz) by @sukjuhong in
#433
* docs(websites-vitepress): cleanup documentation for a beta release by
@lumirlumir in #436
### ♻️ Code Refactoring
* refactor(*): remove `.js` extension in `describe` block by @sukjuhong
in #422
* refactor(bananass): remove `lint` command and consolidate with `build`
by @lumirlumir in #434
* refactor(bananass): cleanup `run` command by @lumirlumir in
#435
### ⬆️ Dependency Updates
* chore(deps): bump globals from 16.0.0 to 16.1.0 by @dependabot in
#419
* chore(deps-dev): bump @types/node from 22.15.16 to 22.15.17 by
@dependabot in #420
* chore(deps): bump eslint-plugin-n from 17.17.0 to 17.18.0 by
@dependabot in #430
* chore(deps-dev): bump lint-staged from 15.5.2 to 16.0.0 by @dependabot
in #431


**Full Changelog**:
v0.1.0-canary.6...v0.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ scope: websites-vitepress Auto-generated label based on Conventional Commits specification for GitHub release notes 🏷️ type: docs Auto-generated label based on Conventional Commits specification for GitHub release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy