Skip to content

docs(websites-vitepress): complete editor-setup.md #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

lumirlumir
Copy link
Owner

This pull request significantly enhances the Korean "Editor Setup" documentation for the Banana Framework by replacing a placeholder with detailed content. It introduces recommendations for setting up and configuring popular code editors, as well as specific guidance for using tools like ESLint and Prettier with VS Code.

Additions to Documentation:

  • Introduction and Overview:

    • Replaced placeholder with a detailed introduction to setting up a development environment for the Banana Framework, including benefits of proper editor configuration.
    • Added a table of contents ([[TOC]]) for better navigation.
  • Editor Recommendations:

    • Provided a list of popular editors (e.g., VS Code, IntelliJ IDEA, Sublime Text, WebStorm, Vim) with descriptions of their features and suitability for JavaScript/TypeScript development.
  • Tool-Specific Setup Instructions:

    • Added detailed steps for installing and configuring ESLint in VS Code, including enabling linting on save.
    • Included guidance for installing and configuring Prettier in VS Code, also with formatting on save instructions.
  • Framework-Specific Configurations:

    • Highlighted Banana Framework's recommended configurations for ESLint (eslint-config-bananass) and Prettier (`prettier

@Copilot Copilot AI review requested due to automatic review settings May 21, 2025 11:52
Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
npm-bananass-websites-vitepress ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 11:57am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
npm-bananass-websites-eslint-config-bananass ⬜️ Skipped (Inspect) May 21, 2025 11:57am

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request significantly enhances the Korean documentation for setting up a development environment for the Banana Framework by replacing a placeholder with detailed editor setup instructions.

  • Detailed introduction with benefits of a proper editor setup and a table of contents for easier navigation
  • Editor recommendations with descriptions and links for popular code editors
  • Step-by-step guidance for installing and configuring ESLint and Prettier in VS Code

@github-actions github-actions bot added 🏷️ scope: websites-vitepress Auto-generated label based on Conventional Commits specification for GitHub release notes 🏷️ type: docs Auto-generated label based on Conventional Commits specification for GitHub release notes labels May 21, 2025
Copy link

Labels have been automatically applied based on the Conventional Commits specification.🏷️

Copy link

codecov bot commented May 21, 2025

Bundle Report

Changes will increase total bundle size by 18.18kB (0.66%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
websites-vitepress-esm 2.45MB 18.18kB (0.75%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: websites-vitepress-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
@localSearchIndexroot.*.js 8.7kB 130.1kB 7.16% ⚠️
get-started_editor-setup.*.js 9.48kB 10.93kB 657.1% ⚠️

Files in get-started_editor-setup.*.js:

  • ./ko/get-started/editor-setup.md → Total Size: 7.96kB

@lumirlumir lumirlumir mentioned this pull request May 20, 2025
68 tasks
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (7bf9395) to head (f1c14d1).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files         190      190           
  Lines       11090    11090           
  Branches       44       44           
=======================================
  Hits        10790    10790           
  Misses        300      300           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf9395...f1c14d1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vercel vercel bot temporarily deployed to Preview – npm-bananass-websites-eslint-config-bananass May 21, 2025 11:57 Inactive
@lumirlumir lumirlumir merged commit 971de7c into main May 21, 2025
20 checks passed
@lumirlumir lumirlumir deleted the docs-update-editor-setup branch May 21, 2025 12:00
lumirlumir added a commit that referenced this pull request Jun 6, 2025
…ch`) (#502)

## Release Information: `v0.1.2`

New release of `lumirlumir/npm-bananass` has arrived! 🎉

This PR bumps the package versions from `v0.1.1` to `v0.1.2` (`patch`).

See
[Actions](https://github.com/lumirlumir/npm-bananass/actions/runs/15485197325)
for more details.

| Info        | Value                      |
| ----------- | -------------------------- |
| Repository  | `lumirlumir/npm-bananass` |
| SEMVER      | `patch`     |
| Pre ID      | `canary`      |
| Short SHA   | 0a7118a       |
| Old Version | `v0.1.1`  |
| New Version | `v0.1.2`  |

<!-- Release notes generated using configuration in .github/release.yml
at main -->

## What's Changed
### 🧰 Chores
* chore(*): update ESLint config and dependabot by @lumirlumir in
#479
### 📝 Documentation
* docs(websites-vitepress): complete `editor-setup.md` by @lumirlumir in
#475
* docs(websites-vitepress): update `other-useful-cli-commands.md` by
@lumirlumir in #476
* docs(websites-vitepress): complete `other-useful-cli-commands.md` by
@lumirlumir in #482
### ♻️ Code Refactoring
* refactor(bananass): streamline command options with new groups for
better organization by @lumirlumir in
#474
### ⬆️ Dependency Updates
* chore(deps-dev): bump textlint from 14.7.1 to 14.7.2 by @dependabot in
#471
* chore(deps): bump webpack from 5.99.7 to 5.99.9 by @dependabot in
#470
* chore(deps-dev): bump @types/node from 22.15.19 to 22.15.21 by
@dependabot in #472
* chore(deps-dev): bump @codecov/vite-plugin from 1.9.0 to 1.9.1 by
@dependabot in #477
* chore(deps): bump globals from 16.1.0 to 16.2.0 by @dependabot in
#480
* chore(deps): bump the babel group across 2 directories with 1 update
by @dependabot in #483
* chore(deps-dev): bump @types/node from 22.15.21 to 22.15.24 by
@dependabot in #485
* chore(deps): bump the next group across 2 directories with 1 update by
@dependabot in #486
* chore(deps-dev): bump lint-staged from 16.0.0 to 16.1.0 by @dependabot
in #487
* chore(deps): bump the babel group across 2 directories with 1 update
by @dependabot in #489
* chore(deps-dev): bump @types/node from 22.15.24 to 22.15.29 by
@dependabot in #490
* chore(deps-dev): bump eslint from 9.27.0 to 9.28.0 by @dependabot in
#492
* chore(deps): bump eslint-plugin-n from 17.18.0 to 17.19.0 by
@dependabot in #491
* chore(deps-dev): bump vitepress-plugin-group-icons from 1.5.5 to 1.6.0
by @dependabot in #498
* chore(deps-dev): bump textlint-rule-allowed-uris from 1.1.0 to 1.1.1
by @dependabot in #500


**Full Changelog**:
v0.1.1...v0.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ scope: websites-vitepress Auto-generated label based on Conventional Commits specification for GitHub release notes 🏷️ type: docs Auto-generated label based on Conventional Commits specification for GitHub release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy