Skip to content

fix: ignore session IDs in stateless mode instead of rejecting them #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2025
Merged

fix: ignore session IDs in stateless mode instead of rejecting them #375

merged 1 commit into from
Jun 8, 2025

Conversation

ezynda3
Copy link
Contributor

@ezynda3 ezynda3 commented Jun 8, 2025 •
edited by coderabbitai bot
Loading

Summary

  • Fixed StatelessSessionIdManager to ignore session IDs completely instead of rejecting them with an error
  • Updated tests to verify that requests with session IDs succeed in stateless mode
  • Added specific test for the tools/list scenario mentioned in the issue

Test plan

  • Updated existing test "Invalid session id" to verify session IDs are ignored in stateless mode
  • Added new test "tools/list with session id in stateless mode" to test the specific scenario from the issue
  • All existing tests continue to pass
  • Verified that both requests with and without session IDs work in stateless mode

🤖 Generated with opencode

Summary by CodeRabbit

  • Bug Fixes

    • Session IDs are now ignored in stateless mode, allowing requests with session ID headers to succeed as expected.

  • Tests

    • Updated and added tests to confirm that session ID headers do not affect request handling in stateless mode.

@ezynda3
fix: ignore session IDs in stateless mode instead of rejecting them
f2fbbd6 
In stateless mode, the server should ignore session-related headers and
process all requests without session validation. Previously, the
StatelessSessionIdManager.Validate() method would return an error when
a session ID was provided, causing legitimate requests to fail with
"Invalid session ID" errors.

This change modifies the StatelessSessionIdManager to completely ignore
session IDs rather than validating or rejecting them, allowing MCP
clients that automatically send session headers (like Cursor IDE) to
work properly with stateless servers.

Fixes #370

🤖 Generated with opencode
Co-Authored-By: opencode <noreply@opencode.ai>
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 8, 2025 •
edited
Loading

Walkthrough

The StatelessSessionIdManager.Validate method was updated to ignore session IDs instead of rejecting them in stateless mode. Corresponding tests were modified and expanded to confirm that session IDs are now ignored and do not affect request handling, ensuring successful responses regardless of session ID presence.

Changes

Files Change Summary
server/streamable_http.go Updated StatelessSessionIdManager.Validate to always ignore session IDs and not return an error.
server/streamable_http_test.go Modified and added tests to verify that session IDs are ignored in stateless mode and requests succeed.

Possibly related issues

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 564b669 and f2fbbd6.

📒 Files selected for processing (2)
  • server/streamable_http.go (1 hunks)
  • server/streamable_http_test.go (2 hunks)
🔇 Additional comments (3)
server/streamable_http.go (1)

610-613: LGTM: Correct implementation of stateless session ID handling.

The change properly implements the stateless behavior by ignoring session IDs completely. Returning (false, nil) ensures that requests with session IDs don't fail unnecessarily in stateless mode, which improves robustness and user experience.

server/streamable_http_test.go (2)

422-461: LGTM: Test correctly updated to reflect new stateless behavior.

The test name change and logic update properly reflect the new behavior where session IDs are ignored in stateless mode. The test now correctly expects a 200 OK response and validates that the request succeeds with a proper JSON-RPC response.

463-502: LGTM: Good test coverage for the specific issue scenario.

This new test case provides excellent coverage for the "tools/list with session id in stateless mode" scenario referenced in the issue. The test verifies that requests with session IDs succeed in stateless mode and return valid responses, ensuring the fix works for the reported use case.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rwjblue-glean rwjblue-glean merged commit c3e9723 into main Jun 8, 2025
4 checks passed
@pottekkat pottekkat mentioned this pull request Jun 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue-glean rwjblue-glean rwjblue-glean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezynda3 @rwjblue-glean
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy