chore: reduce scrolling during clicks #36175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing logic always tries to scroll to a different position after clicking at a wrong hit target. This is done to scroll out from under a sticky/fixed header. However, it does not make sense to scroll if the sticky/fixed header is not a parent of the wrong hit target element, or is a common parent of the hit target and the actual target element. This change restricts the scrolling logic to be only applied when there is a sticky/fixed element in the DOM chain between the hit target and its least common ancestor with the target element.
16d13ae to
eefa0ae
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"4 flaky39286 passed, 818 skipped Merge workflow run. |
pavelfeldman
approved these changes
Jun 3, 2025
Test results for "tests others"1 fatal errors, not part of any test 3 flaky19992 passed, 467 skipped Merge workflow run. |
Test results for "tests 2"1 fatal errors, not part of any test 139 flaky235959 passed, 9420 skipped Merge workflow run. |
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jun 18, 2025
This reverts commit 8d27a06. New test is added to cover the regression.
dgozman
added a commit
that referenced
this pull request
Jun 18, 2025
dgozman
added a commit
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing logic always tries to scroll to a different position after clicking at a wrong hit target. This is done to scroll out from under a sticky/fixed header.
However, it does not make sense to scroll if the sticky/fixed header is not a parent of the wrong hit target element, or is a common parent of the hit target and the actual target element.
This change restricts the scrolling logic to be only applied when there is a sticky/fixed element in the DOM chain between the hit target and its least common ancestor with the target element.