-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix javadoc publication #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix javadoc publication #3561
Conversation
The destination dir was improperly set when translating from groovy DSL to kotlin DSL in 590b24a which prevented the cache and the javadocJar to pick up the right folder. This change avoids setting manually the destination dir and uses the default instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3561 +/- ##
=========================================
Coverage 85.55% 85.55%
Complexity 2955 2955
=========================================
Files 341 341
Lines 8995 8995
Branches 1119 1119
=========================================
Hits 7696 7696
Misses 1009 1009
Partials 290 290 ☔ View full report in Codecov by Sentry. |
In 2c184c9 nexus publish was bumped to 2.0.1, however a task changed name. while this didn't prevent the task to be executed, let's use the correct name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me with one clarifying question.
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [org.mockito:mockito-core](https://github.com/mockito/mockito) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.14.2` -> `5.15.2` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.43` -> `2.29.44` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.43` -> `2.29.44` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.43` -> `2.29.44` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.43` -> `2.29.44` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.43` -> `2.29.44` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.43` -> `2.29.44` | --- ### Release Notes <details> <summary>mockito/mockito (org.mockito:mockito-core)</summary> ### [`v5.15.2`](https://github.com/mockito/mockito/releases/tag/v5.15.2) <sup><sup>*Changelog generated by [Shipkit Changelog Gradle Plugin](https://github.com/shipkit/shipkit-changelog)*</sup></sup> ##### 5.15.2 - 2025-01-02 - [2 commit(s)](mockito/mockito@v5.15.1...v5.15.2) by Brice Dutheil, dependabot\[bot] - Fix javadoc publication [(#​3561)](mockito/mockito#3561) - Bump org.assertj:assertj-core from 3.27.0 to 3.27.1 [(#​3560)](mockito/mockito#3560) - The release job is failed again [(#​3542)](mockito/mockito#3542) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 26ea8877d9bb915b17a2d8978276ca84d2f6e68b
This PR should fix the javadoc publication issues noticed in #3542
listing of published artifacts
Listing of published mockito-core javadoc artifact
Listing of published mockito-junit-jupiter javadoc artifact
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant