Skip to content

Downgrade logback to 1.3.14 for JDK 8 compatibility #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

justin-tay
Copy link
Contributor

Resolves #911

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b33561f) 79.35% compared to head (0cc19fb) 79.32%.
Report is 3 commits behind head on master.

Files Patch % Lines
...n/java/com/networknt/schema/uri/URNURIFactory.java 25.00% 6 Missing ⚠️
src/main/java/com/networknt/schema/JsonSchema.java 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #912      +/-   ##
============================================
- Coverage     79.35%   79.32%   -0.03%     
- Complexity     1217     1224       +7     
============================================
  Files           122      123       +1     
  Lines          3890     3904      +14     
  Branches        736      739       +3     
============================================
+ Hits           3087     3097      +10     
- Misses          515      520       +5     
+ Partials        288      287       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 5535107 into networknt:master Dec 14, 2023
@stevehu
Copy link
Contributor

stevehu commented Dec 14, 2023

@justin-tay Thanks a lot for your help.

@justin-tay justin-tay deleted the logback_master branch January 2, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing as Logback 1.4 requires min JDK 11 but the project still retains JDK 8 compatibility
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy