fix: npm ls --parseable --long output

ruyadorno · claudiahdz · commit 6fe2bdc25e79 · 2020-07-21T12:54:02.000-05:00
PR-URL: #1547 Credit: @ruyadorno Close: #1547 Reviewed-by: @claudiahdz
diff --git a/lib/ls.js b/lib/ls.js
@@ -545,7 +545,7 @@ function makeParseable_ (data, long, dir, depth, parent, d) {
 
   return data.path +
          ':' + (data._id || '') +
-         ':' + (data.realPath !== data.path ? data.realPath : '') +
+         (data.link && data.link !== data.path ? ':' + data.link : '') +
          (data.extraneous ? ':EXTRANEOUS' : '') +
          (data.error && data.path !== path.resolve(npm.globalDir, '..') ? ':ERROR' : '') +
          (data.invalid ? ':INVALID' : '') +
diff --git a/test/tap/ls.js b/test/tap/ls.js
@@ -169,6 +169,40 @@ test('cleanup', function (t) {
   t.done()
 })
 
+test('ls parseable long', function (t) {
+  var fixture = new Tacks(
+    Dir({
+      'npm-test-ls': Dir({
+        'package.json': File({
+          name: 'npm-test-ls',
+          version: '1.0.0',
+          dependencies: {
+            'dep': 'file:../dep'
+          }
+        })
+      }),
+      'dep': Dir({
+        'package.json': File({
+          name: 'dep',
+          version: '1.0.0'
+        })
+      })
+    })
+  )
+  withFixture(t, fixture, function (done) {
+    common.npm([
+      'ls', '--parseable', '--long'
+    ], {
+      cwd: pkgpath
+    }, function (err, code, stdout, stderr) {
+      t.ifErr(err, 'ls succeeded')
+      t.equal(0, code, 'exit 0 on ls')
+      t.notMatch(stdout, /undefined/, 'must not output undefined for non-symlinked items')
+      done()
+    })
+  })
+})
+
 function withFixture (t, fixture, tester) {
   fixture.create(fixturepath)
   common.npm(['install'], {
