fix(core): update getTouchedProjectsFromLockFile to handle deleted/moved projects correctly #31361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 38f50c6.
☁️ Nx Cloud last updated this comment at |
d8a205d to
7297f82
Compare
7297f82 to
38f50c6
Compare
AgentEnder
approved these changes
Jun 2, 2025
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
This fixes a case that was not handled in #31091.
Currently, for pnpm projects with
'projectsAffectedByDependencyUpdates': 'auto', when a project is deleted from the workspace or moved to a different directory, it is added to thegetTouchedProjectsFromLockFilelist asundefined. This results in the following error when you run commands that calculate affected projects:Expected Behavior
getTouchedProjectsFromLockFileshould only return project names for existing projects.Because the
changedProjectPathsentry for deleted/moved projects will not map to a project in theprojectGraphNodesobject, we should filter them out of thegetProjectsNamesFromPathsresult.Related Issue(s)
None that I'm aware of.
I spent some time trying to debug the failingnx release version plans › should pick new versions based on version plans using programmatic apie2e test and am not seeing how my changes could have caused theTypeError: yargs.version is not a functionfailure. 😕 I'd appreciate some help debugging that one! 🙏Update: it eventually passed after rebase with no changes on my end. 🤷